From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chin Liang See <clsee@altera.com>
Date: Tue, 22 Dec 2015 08:21:29 +0800
Subject: [U-Boot] [PATCH] arm: socfpga: Enable ubiload console command
In-Reply-To: <201512220013.21473.marex@denx.de>
References: <1450712174-3262-1-git-send-email-clsee@altera.com>
 <201512220013.21473.marex@denx.de>
Message-ID: <1450743689.1930.2.camel@altera.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, 2015-12-22 at 00:13 +0100, Marek Vasut wrote:
> On Monday, December 21, 2015 at 04:36:14 PM, Chin Liang See wrote:
> > Enabling ubiload command to load kernel image and
> > device tree from mtd part labeled "UBI". ubiload
> > command will search the file from folder /boot.
> 
> ... directory ... this is not windows.

haha let me rephrase this :)

> 
> > Signed-off-by: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Dinh Nguyen <dinh.linux@gmail.com>
> > Cc: Pavel Machek <pavel@denx.de>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Stefan Roese <sr@denx.de>
> > ---
> >  include/configs/socfpga_cyclone5_socdk.h | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/configs/socfpga_cyclone5_socdk.h
> > b/include/configs/socfpga_cyclone5_socdk.h index 3c2e2ae..21b35d8
> > 100644
> > --- a/include/configs/socfpga_cyclone5_socdk.h
> > +++ b/include/configs/socfpga_cyclone5_socdk.h
> > @@ -74,7 +74,10 @@
> >  	"qspirootfstype=jffs2\0" \
> >  	"qspiboot=setenv bootargs " CONFIG_BOOTARGS \
> >  		" root=${qspiroot} rw
> > rootfstype=${qspirootfstype};"\
> > -		"bootm ${loadaddr} - ${fdt_addr}\0"
> > +		"bootm ${loadaddr} - ${fdt_addr}\0" \
> > +	"ubiload=ubi part UBI; ubifsmount ubi0;" \
> > +		"ubifsload ${loadaddr} /boot/${bootimage};" \
> 
> Use && instead of ;, so the loading won't continue in case of
> failure.

This sound good. Let me update this

Thanks
Chin Liang

> 
> > +		"ubifsload ${fdt_addr} /boot/${fdtimage}\0"
> > 
> >  /* The rest of the configuration is shared */
> >  #include <configs/socfpga_common.h>
> 
> Best regards,
> Marek Vasut