From: Jagan Teki <jteki@openedev.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 07/10] spi: Use BIT macro
Date: Mon, 28 Dec 2015 23:02:55 +0530 [thread overview]
Message-ID: <1451323977-24252-8-git-send-email-jteki@openedev.com> (raw)
In-Reply-To: <1451323977-24252-1-git-send-email-jteki@openedev.com>
Used BIT macro like 1 << nr as BIT(nr) where nr is 0...n
Cc: Simon Glass <sjg@chromium.org>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Tested-by: Mugunthan V N <mugunthanvnm@ti.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Jagan Teki <jteki@openedev.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Jagan Teki <jteki@openedev.com>
---
include/spi.h | 38 +++++++++++++++++++-------------------
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/include/spi.h b/include/spi.h
index 82e72ab..f889249 100644
--- a/include/spi.h
+++ b/include/spi.h
@@ -11,26 +11,26 @@
#define _SPI_H_
/* SPI mode flags */
-#define SPI_CPHA 0x01 /* clock phase */
-#define SPI_CPOL 0x02 /* clock polarity */
+#define SPI_CPHA BIT(0) /* clock phase */
+#define SPI_CPOL BIT(1) /* clock polarity */
#define SPI_MODE_0 (0|0) /* (original MicroWire) */
#define SPI_MODE_1 (0|SPI_CPHA)
#define SPI_MODE_2 (SPI_CPOL|0)
#define SPI_MODE_3 (SPI_CPOL|SPI_CPHA)
-#define SPI_CS_HIGH 0x04 /* CS active high */
-#define SPI_LSB_FIRST 0x08 /* per-word bits-on-wire */
-#define SPI_3WIRE 0x10 /* SI/SO signals shared */
-#define SPI_LOOP 0x20 /* loopback mode */
-#define SPI_SLAVE 0x40 /* slave mode */
-#define SPI_PREAMBLE 0x80 /* Skip preamble bytes */
-#define SPI_TX_BYTE 0x100 /* transmit with 1 wire byte */
-#define SPI_TX_QUAD 0x200 /* transmit with 4 wires */
+#define SPI_CS_HIGH BIT(2) /* CS active high */
+#define SPI_LSB_FIRST BIT(3) /* per-word bits-on-wire */
+#define SPI_3WIRE BIT(4) /* SI/SO signals shared */
+#define SPI_LOOP BIT(5) /* loopback mode */
+#define SPI_SLAVE BIT(6) /* slave mode */
+#define SPI_PREAMBLE BIT(7) /* Skip preamble bytes */
+#define SPI_TX_BYTE BIT(8) /* transmit with 1 wire byte */
+#define SPI_TX_QUAD BIT(9) /* transmit with 4 wires */
/* SPI mode_rx flags */
-#define SPI_RX_SLOW (1 << 0)
-#define SPI_RX_FAST (1 << 1)
-#define SPI_RX_DUAL (1 << 2)
-#define SPI_RX_QUAD (1 << 4)
+#define SPI_RX_SLOW BIT(0)
+#define SPI_RX_FAST BIT(1)
+#define SPI_RX_DUAL BIT(2)
+#define SPI_RX_QUAD BIT(4)
/* SPI bus connection options - see enum spi_dual_flash */
#define SPI_CONN_DUAL_SHARED (1 << 0)
@@ -116,12 +116,12 @@ struct spi_slave {
u8 option;
u8 flags;
-#define SPI_XFER_BEGIN 0x01 /* Assert CS before transfer */
-#define SPI_XFER_END 0x02 /* Deassert CS after transfer */
+#define SPI_XFER_BEGIN BIT(0) /* Assert CS before transfer */
+#define SPI_XFER_END BIT(1) /* Deassert CS after transfer */
#define SPI_XFER_ONCE (SPI_XFER_BEGIN | SPI_XFER_END)
-#define SPI_XFER_MMAP 0x04 /* Memory Mapped start */
-#define SPI_XFER_MMAP_END 0x08 /* Memory Mapped End */
-#define SPI_XFER_U_PAGE 0x10
+#define SPI_XFER_MMAP BIT(2) /* Memory Mapped start */
+#define SPI_XFER_MMAP_END BIT(3) /* Memory Mapped End */
+#define SPI_XFER_U_PAGE BIT(4)
};
/**
--
1.9.1
next prev parent reply other threads:[~2015-12-28 17:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 17:32 [U-Boot] [PATCH v2 00/10] spi: Cleanup set Jagan Teki
2015-12-28 17:32 ` [U-Boot] [PATCH v2 01/10] spi: Remove SPI_OPM_RX_EXTN Jagan Teki
2015-12-28 17:32 ` [U-Boot] [PATCH v2 02/10] spi: Remove SPI_OPM_RX_DIO|QIOF Jagan Teki
2015-12-28 17:32 ` [U-Boot] [PATCH v2 03/10] spi: Rename SPI_OPM_RX_* to SPI_RX_* Jagan Teki
2015-12-28 17:32 ` [U-Boot] [PATCH v2 04/10] spi: Rename op_mode_rx to mode_rx Jagan Teki
2015-12-28 17:32 ` [U-Boot] [PATCH v2 05/10] spi: Move flags macro's to spi_slave{} members Jagan Teki
2015-12-28 17:32 ` [U-Boot] [PATCH v2 06/10] spi: Fix bit assignment with flags Jagan Teki
2015-12-28 17:32 ` Jagan Teki [this message]
2015-12-28 17:32 ` [U-Boot] [PATCH v2 08/10] spi: Minor cleanup Jagan Teki
2015-12-28 17:32 ` [U-Boot] [PATCH v2 09/10] sf: Make IO modes at last in read modes Jagan Teki
2015-12-29 6:29 ` Bin Meng
2015-12-29 6:43 ` [U-Boot] [PATCH v2 00/10] spi: Cleanup set Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451323977-24252-8-git-send-email-jteki@openedev.com \
--to=jteki@openedev.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox