public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/8] fdt: Fix up stdout correctly in fdt_fixup_stdout()
Date: Thu, 31 Dec 2015 00:53:03 -0800	[thread overview]
Message-ID: <1451551990-32165-2-git-send-email-bmeng.cn@gmail.com> (raw)
In-Reply-To: <1451551990-32165-1-git-send-email-bmeng.cn@gmail.com>

When CONFIG_OF_STDOUT_VIA_ALIAS is on, always fix up kernel's stdout
string with hardcoded CONFIG_CONS_INDEX.

This actually reverts commit 3e303f748cf57fb23e8ec95ab7eac0074be50e2b
"fdt_support: Add multi-serial support for stdout fixup", as the fix
up in the /aliases node did not work under the following scenarios:
- Not every non-DM serial driver was written to have a driver name
  that conforms the format of "serial%d" or "eserial%d".
- With driver model serial, the stdio_devices[] stores the serial
  device node name in the device tree.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 common/fdt_support.c | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/common/fdt_support.c b/common/fdt_support.c
index 66464db..4ce17d4 100644
--- a/common/fdt_support.c
+++ b/common/fdt_support.c
@@ -131,18 +131,6 @@ static int fdt_fixup_stdout(void *fdt, int chosenoff)
 			      OF_STDOUT_PATH, strlen(OF_STDOUT_PATH) + 1);
 }
 #elif defined(CONFIG_OF_STDOUT_VIA_ALIAS) && defined(CONFIG_CONS_INDEX)
-static void fdt_fill_multisername(char *sername, size_t maxlen)
-{
-	const char *outname = stdio_devices[stdout]->name;
-
-	if (strcmp(outname, "serial") > 0)
-		strncpy(sername, outname, maxlen);
-
-	/* eserial? */
-	if (strcmp(outname + 1, "serial") > 0)
-		strncpy(sername, outname + 1, maxlen);
-}
-
 static int fdt_fixup_stdout(void *fdt, int chosenoff)
 {
 	int err;
@@ -152,9 +140,7 @@ static int fdt_fixup_stdout(void *fdt, int chosenoff)
 	int len;
 	char tmp[256]; /* long enough */
 
-	fdt_fill_multisername(sername, sizeof(sername) - 1);
-	if (!sername[0])
-		sprintf(sername, "serial%d", CONFIG_CONS_INDEX - 1);
+	sprintf(sername, "serial%d", CONFIG_CONS_INDEX - 1);
 
 	aliasoff = fdt_path_offset(fdt, "/aliases");
 	if (aliasoff < 0) {
-- 
1.8.2.1

  reply	other threads:[~2015-12-31  8:53 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-31  8:53 [U-Boot] [PATCH 0/8] arm: ls1021atwr: Convert to driver model and enable serial support Bin Meng
2015-12-31  8:53 ` Bin Meng [this message]
2016-01-08  3:34   ` [U-Boot] [PATCH 1/8] fdt: Fix up stdout correctly in fdt_fixup_stdout() Simon Glass
2016-01-11  3:02     ` Bin Meng
2016-01-11 16:58       ` Simon Glass
2016-01-13  9:14         ` Bin Meng
2016-01-13 20:10           ` Simon Glass
2015-12-31  8:53 ` [U-Boot] [PATCH 2/8] arm: ls1021atwr: Convert to driver model and enable serial support Bin Meng
2015-12-31  8:53 ` [U-Boot] [PATCH 3/8] serial: lpuart: Move CONFIG_FSL_LPUART to Kconfig Bin Meng
2016-01-06  0:25   ` Simon Glass
2016-01-13 18:45   ` Stefan Agner
2015-12-31  8:53 ` [U-Boot] [PATCH 4/8] serial: lpuart: Fix several cosmetic issues Bin Meng
2016-01-06  0:25   ` Simon Glass
2015-12-31  8:53 ` [U-Boot] [PATCH 5/8] serial: lpuart: Call local version of setbrg and putc directly Bin Meng
2016-01-06  0:25   ` Simon Glass
2015-12-31  8:53 ` [U-Boot] [PATCH 6/8] serial: lpuart: Prepare the driver for DM conversion Bin Meng
2016-01-06  0:25   ` Simon Glass
2016-01-13 18:51   ` Stefan Agner
2016-01-14  2:11     ` Bin Meng
2015-12-31  8:53 ` [U-Boot] [PATCH 7/8] serial: lpuart: Add driver model serial support Bin Meng
2016-01-06  0:25   ` Simon Glass
2016-01-11  3:08     ` Bin Meng
2016-01-13  5:49   ` Bhuvanchandra DV
2016-01-13  6:13     ` Bin Meng
2016-01-13  8:07       ` Bhuvanchandra DV
2016-01-13  8:19         ` Bin Meng
2016-01-13 19:20           ` Stefan Agner
2016-01-14  2:24             ` Bin Meng
2016-01-14  8:10               ` Bhuvanchandra DV
2015-12-31  8:53 ` [U-Boot] [PATCH 8/8] arm: ls1021atwr: Enable driver model lpuart serial driver Bin Meng
2016-01-06  0:25   ` Simon Glass
2016-01-06  5:31 ` [U-Boot] [PATCH 0/8] arm: ls1021atwr: Convert to driver model and enable serial support Huan Wang
2016-01-07  2:26   ` Bin Meng
2016-01-07  6:01     ` Huan Wang
2016-01-07  6:15       ` Bin Meng
2016-01-07  6:19         ` Huan Wang
2016-01-07  9:22           ` Bin Meng
2016-01-11  3:10             ` Bin Meng
2016-01-11 16:58               ` Simon Glass
2016-01-13 19:03             ` Stefan Agner
2016-01-14  2:13               ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1451551990-32165-2-git-send-email-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox