public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031
Date: Tue,  5 Jan 2016 17:02:52 -0200	[thread overview]
Message-ID: <1452020574-29179-1-git-send-email-festevam@gmail.com> (raw)

From: Fabio Estevam <fabio.estevam@nxp.com>

Commit 08ad9b068afb88 (" ar8031: modify the config func of ar8031 to
ar8021_config") selected 'ar8021_config' as the configuration function
for AR8031.

The correct would be to use 'ar8035_config' instead as AR8031/AR8035
have the same programming model and even share the same phy driver
in the linux kernel: drivers/net/phy/at803x.c.

Tested on a mx6qsabresd and wandboard, which now can work without
any PHY setup code in the board files.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
This is 2016.04 material.

Zhao Qiang, could you please test this on your platform?

Changes since v1:
- None

 drivers/net/phy/atheros.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c
index d509e30..ba57b1a 100644
--- a/drivers/net/phy/atheros.c
+++ b/drivers/net/phy/atheros.c
@@ -51,7 +51,7 @@ static struct phy_driver AR8031_driver =  {
 	.uid = 0x4dd074,
 	.mask = 0xffffffef,
 	.features = PHY_GBIT_FEATURES,
-	.config = ar8021_config,
+	.config = ar8035_config,
 	.startup = genphy_startup,
 	.shutdown = genphy_shutdown,
 };
-- 
1.9.1

             reply	other threads:[~2016-01-05 19:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05 19:02 Fabio Estevam [this message]
2016-01-05 19:02 ` [U-Boot] [PATCH v2 2/3] mx6sabresd: Simplify the Ethernet PHY configuration Fabio Estevam
2016-01-05 21:07   ` Joe Hershberger
2016-01-05 19:02 ` [U-Boot] [PATCH v2 3/3] wandboard: " Fabio Estevam
2016-01-05 21:06   ` Joe Hershberger
2016-01-07 16:50   ` Stefano Babic
2016-01-05 19:06 ` [U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031 Joe Hershberger
2016-01-06  5:17 ` Qiang Zhao
2016-01-06  9:47   ` Fabio Estevam
2016-01-06 12:40     ` Stefano Babic
2016-01-06  6:19 ` Qiang Zhao
2016-01-06  9:25 ` Qiang Zhao
2016-01-07 16:50 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452020574-29179-1-git-send-email-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox