[U-Boot] [PATCH v2 06/13] MIPS: Add support for Microchip PIC32MZ[DA] family.

Daniel Schwierzeck
2016-01-09T21:06:17Z

Am Mittwoch, den 06.01.2016, 15:03 +0530 schrieb Purna Chandra Mandal:
> On 01/06/2016 01:53 AM, Daniel Schwierzeck wrote:
> > 2016-01-04 15:01 GMT+01:00 Purna Chandra Mandal <
> > purna.mandal at microchip.com>:
> > > Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
> > >
> > > ---
> > >
> > > Changes in v2:
> > > - drop unnecessary board_early_init_f()
> > > - use LEAF(), END() macros for lowlevel_init
> > > - move initialization of board_init_f() argument to common
> > > start.S
> > > - move initdram() from board/microchip/ to mach-pic32/cpu.c
> > > - remove MIPS virtual address in favor of physical address in dts
> > > file
> > >
> > > arch/mips/cpu/start.S | 2 +
> > > arch/mips/dts/pic32mzda.dtsi | 64 +++++++++++++
> > > arch/mips/mach-pic32/Kconfig | 16 +++-
> > > arch/mips/mach-pic32/Makefile | 2 +-
> > > arch/mips/mach-pic32/cpu.c | 146
> > > ++++++++++++++++++++++++++++++
> > > arch/mips/mach-pic32/include/mach/pic32.h | 3 +
> > > arch/mips/mach-pic32/lowlevel_init.S | 27 ++++++
> > > arch/mips/mach-pic32/reset.c | 36 ++++++++
> > > 8 files changed, 294 insertions(+), 2 deletions(-)
> > > create mode 100644 arch/mips/dts/pic32mzda.dtsi
> > > create mode 100644 arch/mips/mach-pic32/lowlevel_init.S
> > > create mode 100644 arch/mips/mach-pic32/reset.c
> > >
> > > diff --git a/arch/mips/cpu/start.S b/arch/mips/cpu/start.S
> > > index e95cdca..a7e6722 100644
> > > --- a/arch/mips/cpu/start.S
> > > +++ b/arch/mips/cpu/start.S
> > > @@ -185,6 +185,8 @@ reset:
> > > PTR_ADDU t0, k0, GD_MALLOC_BASE # gd->malloc_base offset
> > > sw sp, 0(t0)
> > > #endif
> > > + /* Initialize args to zero. */
> > > + li a0, 0x0
> > please create a separate patch for this change. Also the code must
> > be
> > compatible with MIPS64 now, so please do:
> >
> > PTR_LI a0, 0
>
> ack.

I was mistaken, li would work too. Anyway a better approach would be

move a0, zero

Please use that, thanks.

--
- Daniel