* [U-Boot] [PATCH V2] common: cli_simple: use strlcpy instead of strcpy
@ 2016-01-10 5:01 Peng Fan
2016-01-11 16:58 ` Simon Glass
2016-01-14 13:22 ` [U-Boot] [U-Boot, " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Peng Fan @ 2016-01-10 5:01 UTC (permalink / raw)
To: u-boot
Report Coverity log:
Destination buffer too small (STRING_OVERFLOW)
string_overflow: You might overrun the 1024 byte destination string
lastcommand by writing 1025 bytes from console_buffer
Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: Heiko Schocher <hs@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
---
Changes V2:
Use strlcpy instead of strncpy.
common/cli_simple.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/common/cli_simple.c b/common/cli_simple.c
index 9c3d073..bb96aae 100644
--- a/common/cli_simple.c
+++ b/common/cli_simple.c
@@ -276,7 +276,8 @@ void cli_simple_loop(void)
flag = 0; /* assume no special flags for now */
if (len > 0)
- strcpy(lastcommand, console_buffer);
+ strlcpy(lastcommand, console_buffer,
+ CONFIG_SYS_CBSIZE + 1);
else if (len == 0)
flag |= CMD_FLAG_REPEAT;
#ifdef CONFIG_BOOT_RETRY_TIME
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH V2] common: cli_simple: use strlcpy instead of strcpy
2016-01-10 5:01 [U-Boot] [PATCH V2] common: cli_simple: use strlcpy instead of strcpy Peng Fan
@ 2016-01-11 16:58 ` Simon Glass
2016-01-14 13:22 ` [U-Boot] [U-Boot, " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2016-01-11 16:58 UTC (permalink / raw)
To: u-boot
On 9 January 2016 at 22:01, Peng Fan <van.freenix@gmail.com> wrote:
> Report Coverity log:
> Destination buffer too small (STRING_OVERFLOW)
> string_overflow: You might overrun the 1024 byte destination string
> lastcommand by writing 1025 bytes from console_buffer
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> ---
>
> Changes V2:
> Use strlcpy instead of strncpy.
>
> common/cli_simple.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [U-Boot, V2] common: cli_simple: use strlcpy instead of strcpy
2016-01-10 5:01 [U-Boot] [PATCH V2] common: cli_simple: use strlcpy instead of strcpy Peng Fan
2016-01-11 16:58 ` Simon Glass
@ 2016-01-14 13:22 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-01-14 13:22 UTC (permalink / raw)
To: u-boot
On Sun, Jan 10, 2016 at 01:01:22PM +0800, Peng Fan wrote:
> Report Coverity log:
> Destination buffer too small (STRING_OVERFLOW)
> string_overflow: You might overrun the 1024 byte destination string
> lastcommand by writing 1025 bytes from console_buffer
>
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160114/b0a0cd07/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-14 13:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-10 5:01 [U-Boot] [PATCH V2] common: cli_simple: use strlcpy instead of strcpy Peng Fan
2016-01-11 16:58 ` Simon Glass
2016-01-14 13:22 ` [U-Boot] [U-Boot, " Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox