public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: phy: genphy: Allow overwriting features
Date: Mon, 11 Jan 2016 17:50:37 +0000	[thread overview]
Message-ID: <1452534633.4294.10.camel@synopsys.com> (raw)
In-Reply-To: <CANr=Z=ZeaXvc8yN7wGVwi6Vc-Rc0DY3S9eYW8nXTbCx6_2z4Gw@mail.gmail.com>

Hi Joe,

On Mon, 2016-01-11 at 10:54 -0600, Joe Hershberger wrote:
> Hi Alexey,
> 
> On Mon, Jan 11, 2016 at 3:45 AM, Alexey Brodkin
> <Alexey.Brodkin@synopsys.com> wrote:
> > Hi Joe,
> > 
> > On Wed, 2015-12-23 at 19:44 +0300, Alexey Brodkin wrote:
> > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > 
> > > of_set_phy_supported allows overwiting hardware capabilities of
> > > a phy with values from the devicetree. This does not work with
> > > the genphy driver though because the genphys config_init function
> > > will overwrite all values adjusted by of_set_phy_supported. Fix
> > > this by initialising the genphy features in the phy_driver struct
> > > and in config_init just limit the features to the ones the hardware
> > > can actually support. The resulting features are a subset of the
> > > devicetree specified features and the hardware features.
> > > 
> > > This is a copy of the patch from Linux kernel, see
> > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c242a47238fa2a6a54af8a16e62b54e6e031d4bc
> > > 
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > > Cc: Joe Hershberger <joe.hershberger@ni.com>
> > > ---
> > 
> > Any chance for that one to be applied?
> 
> I'll review when the merge window opens.
> 
> > This patch is required to implement phy max
> > speed limitation by subsequent patches.
> 
> Any reason you did not send as a series if there are dependencies?

I thought about putting some of those patches in one series initially but then
decided to send them separately.

Even though together they solve one particular problem (ability to
set phy speed limit) they are a bit different by their nature.

http://patchwork.ozlabs.org/patch/560608/,
http://patchwork.ozlabs.org/patch/560634/ and
http://patchwork.ozlabs.org/patch/560635/ are back-ports from Linux kernel
and could be actually applied separately because they are not related to
each other.

Following two are really preparatory for implementing capping:
http://patchwork.ozlabs.org/patch/560636/
http://patchwork.ozlabs.org/patch/560637/

...in patch I actually forgot to send out... (will do it shortly).

And finally http://patchwork.ozlabs.org/patch/560638/ really a plain fix
for DW GMAC driver which may happen in case of phy force set lower than
possible. So it will easily manifest if all above is applied.

That said it was conscious decision but probably incorrect one.

If you do think it all fits well in a series I'll re-send it that way.

-Alexey

  reply	other threads:[~2016-01-11 17:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23 16:44 [U-Boot] [PATCH] net: phy: genphy: Allow overwriting features Alexey Brodkin
2016-01-11  9:45 ` Alexey Brodkin
2016-01-11 16:54   ` Joe Hershberger
2016-01-11 17:50     ` Alexey Brodkin [this message]
2016-01-11 17:55       ` Joe Hershberger
2016-01-11 17:57         ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452534633.4294.10.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox