public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Chin Liang See <clsee@altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] socfpga: Modify qts-filter args to allow input for bsp generated files and quartus project directories
Date: Tue, 12 Jan 2016 08:26:58 +0800	[thread overview]
Message-ID: <1452558418.1947.6.camel@altera.com> (raw)
In-Reply-To: <1452555198-11860-1-git-send-email-dwesterg@gmail.com>

On Mon, 2016-01-11 at 15:33 -0800, Dalon Westergreen wrote:
> The hps_isw_handoff and bsp/generated folders are typically not in
> the same path. This patch adds support for specifying the different
> input directories for the bsp and quartus projects.
> 
> Signed-off-by: Dalon Westergreen <dwesterg@gmail.com>
> Acked-by: Marek Vasut <marex@denx.de>
> ---
> Changes for v2:
>   - Add commit message
> Changes for v3:
>   - Fix line length issues
> ---
>  arch/arm/mach-socfpga/qts-filter.sh | 74 +++++++++++++++++++++------
> ----------
>  1 file changed, 43 insertions(+), 31 deletions(-)
> 

Looks good to me with minor nickpicking on the help message.

Acked-by: Chin Liang See <clsee@altera.com>

Thanks
Chin Liang

> diff --git a/arch/arm/mach-socfpga/qts-filter.sh b/arch/arm/mach
> -socfpga/qts-filter.sh
> index c1640bc..b81a4e1 100755
> --- a/arch/arm/mach-socfpga/qts-filter.sh
> +++ b/arch/arm/mach-socfpga/qts-filter.sh
> 

[..]

> @@ -176,30 +184,34 @@ EOF
>  }
>  
>  usage() {
> -	echo "$0 [soc_type] [input_dir] [output_dir]"
> +	echo "$0 [soc_type] [input_qts_dir] [input_bsp_dir]
> [output_dir]"
>  	echo "Process QTS-generated headers into U-Boot compatible
> ones."
>  	echo ""
> -	echo "  soc_type\t\tType of SoC, either 'cyclone5' or
> 'arria5',"
> -	echo "  input_dir\t\tDirectory with the QTS project."
> -	echo "  output_dir\t\tDirectory to store the U-Boot
> compatible headers."
> +	echo "  soc_type - Type of SoC, either 'cyclone5' or
> 'arria5',"
> +	echo "  input_qts_dir - Directory with compiled Quartus
> project."

We can put Directory where the Quartus project file is located.

> +	echo "  input_bsp_dir - Directory with generated output
> from"
> +	echo "                  the bsp-editor."

We can put Directory where the bsp-editor file settings.bsp is located.

> +	echo "  output_dir - Directory to store the U-Boot
> compatible headers."
>  	echo ""
>  }
>  
>  soc="$1"
> -in_dir="$2"
> -out_dir="$3"
> +in_qts_dir="$2"
> +in_bsp_dir="$3"
> +out_dir="$4"
>  
> -if [ "$#" -ne 3 ] ; then
> +if [ "$#" -ne 4 ] ; then
>  	usage
>  	exit 1
>  fi
>  
> -if [ ! -d "${in_dir}" -o ! -d "${out_dir}" -o -z "${soc}" ] ; then
> +if [ ! -d "${in_qts_dir}" -o ! -d "${in_bsp_dir}" -o \
> +	! -d "${out_dir}" -o -z "${soc}" ] ; then
>  	usage
>  	exit 3
>  fi
>  
> -process_iocsr_config  "${soc}" "${in_dir}" "${out_dir}"
> -process_pinmux_config "${soc}" "${in_dir}" "${out_dir}"
> -process_pll_config    "${soc}" "${in_dir}" "${out_dir}"
> -process_sdram_config  "${soc}" "${in_dir}" "${out_dir}"
> +process_iocsr_config  "${soc}" "${in_qts_dir}" "${in_bsp_dir}"
> "${out_dir}"
> +process_pinmux_config "${soc}" "${in_qts_dir}" "${in_bsp_dir}"
> "${out_dir}"
> +process_pll_config    "${soc}" "${in_qts_dir}" "${in_bsp_dir}"
> "${out_dir}"
> +process_sdram_config  "${soc}" "${in_qts_dir}" "${in_bsp_dir}"
> "${out_dir}"

  parent reply	other threads:[~2016-01-12  0:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11 23:33 [U-Boot] [PATCH v3] socfpga: Modify qts-filter args to allow input for bsp generated files and quartus project directories Dalon Westergreen
2016-01-12  0:23 ` Marek Vasut
2016-01-12  0:26 ` Chin Liang See [this message]
2016-01-12  0:31   ` Marek Vasut
2016-01-12  0:50     ` Chin Liang See
2016-01-12  2:48       ` Marek Vasut
2016-01-13  2:05         ` Chin Liang See
2016-01-13  2:07           ` Marek Vasut
2016-01-13  2:23             ` Chin Liang See
2016-01-13  2:34               ` Marek Vasut
2016-01-13  2:45                 ` Chin Liang See
2016-01-13  2:55                   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452558418.1947.6.camel@altera.com \
    --to=clsee@altera.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox