From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Schwierzeck Date: Thu, 21 Jan 2016 16:34:26 +0100 Subject: [U-Boot] [PATCH] bootm: fix size arg of flush_cache() in bootm_load_os(). In-Reply-To: <1453279059-10967-1-git-send-email-purna.mandal@microchip.com> References: <1453279059-10967-1-git-send-email-purna.mandal@microchip.com> Message-ID: <1453390466.4370.14.camel@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am Mittwoch, den 20.01.2016, 14:07 +0530 schrieb Purna Chandra Mandal: > Variable _load_end_ points to end address of uncompressed buffer > (*not* uncomress_buffer_end / sizeof(ulong)), so multipling > uncompressed > size with sizeof(ulong) is grossly incorrect in flush_cache(). > It might lead to access of address beyond valid memory range and hang > the CPU. > > Tested on MIPS architecture by using compressed(gzip, lzma) > and uncompressed uImage. > > Signed-off-by: Purna Chandra Mandal Reviewed-by: Daniel Schwierzeck > --- > > common/bootm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/bootm.c b/common/bootm.c > index 58936ca..99d574d 100644 > --- a/common/bootm.c > +++ b/common/bootm.c > @@ -435,7 +435,7 @@ static int bootm_load_os(bootm_headers_t *images, > unsigned long *load_end, > bootstage_error(BOOTSTAGE_ID_DECOMP_IMAGE); > return err; > } > - flush_cache(load, (*load_end - load) * sizeof(ulong)); > + flush_cache(load, *load_end - load); > > debug(" kernel loaded at 0x%08lx, end = 0x%08lx\n", load, > *load_end); > bootstage_mark(BOOTSTAGE_ID_KERNEL_LOADED); -- - Daniel