From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] kbuild: use $(call cmd, ) rather than $(call if_changed, ) where possible
Date: Fri, 05 Feb 2016 08:11:02 +0000 [thread overview]
Message-ID: <1454659862.7481.72.camel@hellion.org.uk> (raw)
In-Reply-To: <CAK7LNAS2ms0v8oVP_Rd+HykZuxSkjL5UZ4og4EUwOtBsrt3uTw@mail.gmail.com>
On Fri, 2016-02-05 at 14:33 +0900, Masahiro Yamada wrote:
> >> These build commands are constant (mostly, just concatenating
> images,
> >> or just copying). No need to use $(call if_changed,...) for them.
> >
> >
> > I disagree, since I believe this change means that if someone /does/ change
> > the command in the future (e.g. to replace it with more complex processing,
> > or add additional dependencies), then the Makefile will/may not
> > automatically rebuild those targets, which is the entire point of using
> > if_changed, and is a huge benefit of using Kbuild.
>
> I do not a strong opinion about this, so
> I will drop 3/5 and submit v2.
I think the same logic applies to that part of the change in patch 2 as
well.
Ian.
next prev parent reply other threads:[~2016-02-05 8:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 12:05 [U-Boot] [PATCH 0/5] kbuild fixes Masahiro Yamada
2016-02-03 12:05 ` [U-Boot] [PATCH 1/5] kbuild: remove unneeded ifdef conditionals around build rules Masahiro Yamada
2016-02-03 12:05 ` [U-Boot] [PATCH 2/5] kbuild: sunxi: fix build rule of sunxi-spl.bin Masahiro Yamada
2016-02-03 12:05 ` [U-Boot] [PATCH 3/5] kbuild: use $(call cmd, ) rather than $(call if_changed, ) where possible Masahiro Yamada
2016-02-03 12:18 ` Albert ARIBAUD
2016-02-03 12:20 ` Albert ARIBAUD
2016-02-03 15:57 ` Stephen Warren
2016-02-05 5:33 ` Masahiro Yamada
2016-02-05 8:11 ` Ian Campbell [this message]
2016-02-03 12:05 ` [U-Boot] [PATCH 4/5] kbuild: add missing FORCE where $(call if_changed, ) is used Masahiro Yamada
2016-02-03 12:05 ` [U-Boot] [PATCH 5/5] kbuild: fix build rule of u-boot-spl.dtb Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454659862.7481.72.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox