From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Date: Fri, 05 Feb 2016 08:11:02 +0000 Subject: [U-Boot] [PATCH 3/5] kbuild: use $(call cmd, ) rather than $(call if_changed, ) where possible In-Reply-To: References: <1454501114-4346-1-git-send-email-yamada.masahiro@socionext.com> <1454501114-4346-4-git-send-email-yamada.masahiro@socionext.com> <56B22379.4040203@wwwdotorg.org> Message-ID: <1454659862.7481.72.camel@hellion.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, 2016-02-05 at 14:33 +0900, Masahiro Yamada wrote: > >> These build commands are constant (mostly, just concatenating > images, > >> or just copying). No need to use $(call if_changed,...) for them. > > > > > > I disagree, since I believe this change means that if someone /does/ change > > the command in the future (e.g. to replace it with more complex processing, > > or add additional dependencies), then the Makefile will/may not > > automatically rebuild those targets, which is the entire point of using > > if_changed, and is a huge benefit of using Kbuild. > > I do not a strong opinion about this, so > I will drop 3/5 and submit v2. I think the same logic applies to that part of the change in patch 2 as well. Ian.