From: Steve Rae <srae@broadcom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] fastboot: sparse: fix block addressing for don't care chunk type
Date: Tue, 9 Feb 2016 11:19:10 -0800 [thread overview]
Message-ID: <1455045551-12971-1-git-send-email-srae@broadcom.com> (raw)
When 7bfc3b1 (sparse: Refactor chunk parsing function) was implemented,
it dropped 9981945 (aboot: fix block addressing for don't care chunk type).
This re-implements the required fix for the "don't care chunk type"...
Signed-off-by: Steve Rae <srae@broadcom.com>
---
Changes in v2:
Handle MMC device differently than the NAND device.
common/image-sparse.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/common/image-sparse.c b/common/image-sparse.c
index dffe844..ef0d232 100644
--- a/common/image-sparse.c
+++ b/common/image-sparse.c
@@ -330,9 +330,13 @@ int store_sparse_image(sparse_storage_t *storage, void *storage_priv,
* and go on parsing the rest of the chunks
*/
if (chunk_header->chunk_type == CHUNK_TYPE_DONT_CARE) {
- skipped += sparse_block_size_to_storage(chunk_header->chunk_sz,
- storage,
- sparse_header);
+ blkcnt = sparse_block_size_to_storage(chunk_header->chunk_sz,
+ storage,
+ sparse_header);
+#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV
+ total_blocks += blkcnt;
+#endif
+ skipped += blkcnt;
continue;
}
@@ -380,7 +384,7 @@ int store_sparse_image(sparse_storage_t *storage, void *storage_priv,
printf("........ wrote %d blocks to '%s'\n", total_blocks,
storage->name);
- if ((total_blocks + skipped) !=
+ if (total_blocks !=
sparse_block_size_to_storage(sparse_header->total_blks,
storage, sparse_header)) {
printf("sparse image write failure\n");
--
1.8.5
next reply other threads:[~2016-02-09 19:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 19:19 Steve Rae [this message]
2016-02-09 19:19 ` [U-Boot] [PATCH v2 2/2] fastboot: sparse: remove unnecessary logging Steve Rae
2016-02-29 22:38 ` Steve Rae
2016-03-09 20:47 ` Maxime Ripard
2016-03-23 22:15 ` Steve Rae
2016-04-12 2:28 ` [U-Boot] [U-Boot, v2, " Tom Rini
2016-02-29 22:37 ` [U-Boot] [PATCH v2 1/2] fastboot: sparse: fix block addressing for don't care chunk type Steve Rae
2016-03-09 20:46 ` Maxime Ripard
2016-03-23 22:14 ` Steve Rae
2016-04-12 2:28 ` [U-Boot] [U-Boot, v2, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455045551-12971-1-git-send-email-srae@broadcom.com \
--to=srae@broadcom.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox