From: Jagan Teki <jteki@openedev.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 14/76] sf: Use erasesize instead of sector_size
Date: Mon, 15 Feb 2016 02:18:13 +0530 [thread overview]
Message-ID: <1455482955-19053-14-git-send-email-jteki@openedev.com> (raw)
In-Reply-To: <1455482955-19053-1-git-send-email-jteki@openedev.com>
For computing proper sector_size the below patch
assigned erase_size which is a proper sector
computation size, so this patch directly used
erasesize instead of assignment.
"sf: Fix to compute proper sector_size"
(sha1: c650ca7b4c160193791dc7a52381c71c6a29e871)
Cc: Simon Glass <sjg@chromium.org>
Cc: Bin Meng <bmeng.cn@gmail.com>
Cc: Mugunthan V N <mugunthanvnm@ti.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Signed-off-by: Jagan Teki <jteki@openedev.com>
---
cmd/sf.c | 20 ++++++++++----------
drivers/dfu/dfu_sf.c | 8 ++++----
drivers/mtd/spi/sf_mtd.c | 2 +-
drivers/mtd/spi/spi_flash.c | 3 ---
4 files changed, 15 insertions(+), 18 deletions(-)
diff --git a/cmd/sf.c b/cmd/sf.c
index e4d1274..c20c901 100644
--- a/cmd/sf.c
+++ b/cmd/sf.c
@@ -53,8 +53,8 @@ static int sf_parse_len_arg(char *arg, ulong *len)
if (ep == arg || *ep != '\0')
return -1;
- if (round_up_len && flash->sector_size > 0)
- *len = ROUND(len_arg, flash->sector_size);
+ if (round_up_len && flash->erasesize > 0)
+ *len = ROUND(len_arg, flash->erasesize);
else
*len = len_arg;
@@ -171,10 +171,10 @@ static const char *spi_flash_update_block(struct spi_flash *flash, u32 offset,
{
char *ptr = (char *)buf;
- debug("offset=%#x, sector_size=%#x, len=%#zx\n",
- offset, flash->sector_size, len);
+ debug("offset=%#x, erasesize=%#x, len=%#zx\n",
+ offset, flash->erasesize, len);
/* Read the entire sector so to allow for rewriting */
- if (spi_flash_read(flash, offset, flash->sector_size, cmp_buf))
+ if (spi_flash_read(flash, offset, flash->erasesize, cmp_buf))
return "read";
/* Compare only what is meaningful (len) */
if (memcmp(cmp_buf, buf, len) == 0) {
@@ -184,15 +184,15 @@ static const char *spi_flash_update_block(struct spi_flash *flash, u32 offset,
return NULL;
}
/* Erase the entire sector */
- if (spi_flash_erase(flash, offset, flash->sector_size))
+ if (spi_flash_erase(flash, offset, flash->erasesize))
return "erase";
/* If it's a partial sector, copy the data into the temp-buffer */
- if (len != flash->sector_size) {
+ if (len != flash->erasesize) {
memcpy(cmp_buf, buf, len);
ptr = cmp_buf;
}
/* Write one complete sector */
- if (spi_flash_write(flash, offset, flash->sector_size, ptr))
+ if (spi_flash_write(flash, offset, flash->erasesize, ptr))
return "write";
return NULL;
@@ -223,12 +223,12 @@ static int spi_flash_update(struct spi_flash *flash, u32 offset,
if (end - buf >= 200)
scale = (end - buf) / 100;
- cmp_buf = memalign(ARCH_DMA_MINALIGN, flash->sector_size);
+ cmp_buf = memalign(ARCH_DMA_MINALIGN, flash->erasesize);
if (cmp_buf) {
ulong last_update = get_timer(0);
for (; buf < end && !err_oper; buf += todo, offset += todo) {
- todo = min_t(size_t, end - buf, flash->sector_size);
+ todo = min_t(size_t, end - buf, flash->erasesize);
if (get_timer(last_update) > 100) {
printf(" \rUpdating, %zu%% %lu B/s",
100 - (end - buf) / scale,
diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c
index 9702eee..13e7f92 100644
--- a/drivers/dfu/dfu_sf.c
+++ b/drivers/dfu/dfu_sf.c
@@ -25,8 +25,8 @@ static int dfu_read_medium_sf(struct dfu_entity *dfu, u64 offset, void *buf,
static u64 find_sector(struct dfu_entity *dfu, u64 start, u64 offset)
{
- return (lldiv((start + offset), dfu->data.sf.dev->sector_size)) *
- dfu->data.sf.dev->sector_size;
+ return (lldiv((start + offset), dfu->data.sf.dev->erasesize)) *
+ dfu->data.sf.dev->erasesize;
}
static int dfu_write_medium_sf(struct dfu_entity *dfu,
@@ -36,7 +36,7 @@ static int dfu_write_medium_sf(struct dfu_entity *dfu,
ret = spi_flash_erase(dfu->data.sf.dev,
find_sector(dfu, dfu->data.sf.start, offset),
- dfu->data.sf.dev->sector_size);
+ dfu->data.sf.dev->erasesize);
if (ret)
return ret;
@@ -123,7 +123,7 @@ int dfu_fill_entity_sf(struct dfu_entity *dfu, char *devstr, char *s)
return -ENODEV;
dfu->dev_type = DFU_DEV_SF;
- dfu->max_buf_size = dfu->data.sf.dev->sector_size;
+ dfu->max_buf_size = dfu->data.sf.dev->erasesize;
st = strsep(&s, " ");
if (!strcmp(st, "raw")) {
diff --git a/drivers/mtd/spi/sf_mtd.c b/drivers/mtd/spi/sf_mtd.c
index 0b9cb62..9a8302d 100644
--- a/drivers/mtd/spi/sf_mtd.c
+++ b/drivers/mtd/spi/sf_mtd.c
@@ -93,7 +93,7 @@ int spi_flash_mtd_register(struct spi_flash *flash)
/* Only uniform flash devices for now */
sf_mtd_info.numeraseregions = 0;
- sf_mtd_info.erasesize = flash->sector_size;
+ sf_mtd_info.erasesize = flash->erasesize;
return add_mtd_device(&sf_mtd_info);
}
diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c
index 17eb0e9..891e1ec 100644
--- a/drivers/mtd/spi/spi_flash.c
+++ b/drivers/mtd/spi/spi_flash.c
@@ -1091,9 +1091,6 @@ int spi_flash_scan(struct spi_flash *flash)
flash->erasesize = flash->sector_size;
}
- /* Now erase size becomes valid sector size */
- flash->sector_size = flash->erasesize;
-
/* Look for the fastest read cmd */
cmd = fls(params->e_rd_cmd & spi->mode_rx);
if (cmd) {
--
1.9.1
next prev parent reply other threads:[~2016-02-14 20:48 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 20:48 [U-Boot] [PATCH v6 01/76] mtd: Add m25p80 driver Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 02/76] mtd: Add Kconfig entry for MTD_M25P80 Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 03/76] mtd: Add SPI-NOR core support Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 04/76] doc: device-tree-bindings: jedec, spi-nor Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 05/76] mtd: spi-nor: Add Kconfig entry for MTD_SPI_NOR Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 06/76] mtd: spi-nor: Add kconfig for MTD_SPI_NOR_USE_4K_SECTORS Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 07/76] mtd: spi-nor: Add MTD support Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 08/76] mtd: spi-nor: Add spi_nor support in m25p80 Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 09/76] mtd: spi-nor: Add dm spi-nor probing Jagan Teki
2016-02-15 9:15 ` Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 10/76] mtd: spi-nor: Add spi_flash_probe for mtd-dm-spi-nor Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 11/76] mtd: spi-nor: Add spi_flash_free " Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 12/76] mtd: spi-nor: m25p80: Add spi_nor support for non-dm Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 13/76] sf: Rename erase_size to erasesize Jagan Teki
2016-02-14 20:48 ` Jagan Teki [this message]
2016-02-14 20:48 ` [U-Boot] [PATCH v6 15/76] sf: Use uint64_t for flash->size Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 16/76] spi_flash: Use mtd_info operation for SPI-NOR Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 17/76] spi_flash: Use spi_flash_t instead of struct spi_flash Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 18/76] mtd: spi-nor: Move spi_read_then_write to spi layer Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 19/76] spi: Rename spi_read_then_write to spi_write_then_read Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 20/76] mtd: spi-nor: Rename SPI_FLASH_BAR to SPI_NOR_BAR Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 21/76] mtd: spi-nor: Add Kconfig entry for SPI_NOR_BAR Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 22/76] mtd: spi-nor: Copy spl files from drivers/mtd/spi Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 23/76] mtd: spi-nor: spl: Follow ascending order of include headers Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 24/76] mtd: spi-nor: fsl_espi_spl: Use mtd_info Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 25/76] mtd: spi-nor: spi_spl_load: " Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 26/76] mtd: spi-nor: Add flash vendor Kconfig entries Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 27/76] arm: zynq: Kconfig: Select MTD uclass Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 28/76] arm: zynq: Kconfig: Drop DM_SPI_FLASH Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 29/76] defconfigs: zynq_microzed: Drop CONFIG_SPI_FLASH Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 30/76] defconfig: zynq_microzed: Enable CONFIG_MTD_M25P80 Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 31/76] defconfig: zynq_microzed: Enable CONFIG_MTD_SPI_NOR Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 32/76] spl: Add CONFIG_SPL_SPI_NOR_SUPPORT Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 33/76] configs: zynq: Use CONFIG_SPL_SPI_NOR_SUPPORT Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 34/76] configs: zynq: Use CONFIG_SPL_MTD_SUPPORT Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 35/76] mtd: spi-nor: Copy sf_dataflash Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 36/76] mtd: dataflash: Remove unneeded spi data Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 37/76] mtd: dataflash: Move flash id detection into jedec_probe Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 38/76] mtd: dataflash: Fix add_dataflash return logic Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 39/76] mtd: dataflash: Add UCLASS_MTD support Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 40/76] mtd: dataflash: Use spi_write_then_read Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 41/76] mtd: dataflash: Drop sf_internal.h Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 42/76] mtd: dataflash: Minor cleanups Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 43/76] mtd: Rename sf_dataflash.c to mtd_dataflash.c Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 44/76] mtd: spi-nor: Add Kconfig entry for mtd_dataflash Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 45/76] mtd: dataflash: Add MTD_DATAFLASH_WRITE_VERIFY Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 46/76] mtd: spi-nor: Add kconfig MTD_DATAFLASH_WRITE_VERIFY Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 47/76] configs: ls1021aqds: Drop DM_SPI_FLASH and DATAFLASH Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 48/76] defconfig: ls1021aqds_qspi: Enable SPI-NOR Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 49/76] defconfig: ls1021aqds_qspi: Enable CONFIG_MTD_DATAFLASH Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 50/76] mtd: spi-nor: Copy sandbox Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 51/76] mtd: spi-nor: sandbox: Use spi-nor header Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 52/76] mtd: spi-nor: Add SPI_NOR_SANBOX Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 53/76] sandbox: kconfig: Drop DM_SPI_FLASH Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 54/76] sandbox: kconfig: Select MTD uclass Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 55/76] defconfigs: sandbox: Enable SPI-NOR Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 56/76] mtd: sandbox: Use CONFIG_MTD_SPI_NOR Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 57/76] defconfigs: sandbox: Enable SPI_NOR_SANDBOX Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 58/76] spi_flash: Use spi_flash_t Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 59/76] mtd: spi-nor: Add CONFIG_SPI_NOR_MISC Jagan Teki
2016-02-14 20:48 ` [U-Boot] [PATCH v6 60/76] config: Enable SPI-NOR framework Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 61/76] spi-nor: Use CONFIG_MTD_SPI_NOR Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 62/76] configs: " Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 63/76] configs: Use CONFIG_SPI_NOR_BAR Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 64/76] configs: spi-nor: Add new flash vendor configs Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 65/76] configs: Use CONFIG_SPI_NOR_MISC Jagan Teki
2016-02-17 8:53 ` Bin Meng
2016-02-17 9:05 ` Jagan Teki
2016-02-17 9:09 ` Bin Meng
2016-02-17 9:31 ` Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 66/76] spi: Drop mode_rx Jagan Teki
2016-02-15 11:16 ` Bin Meng
2016-02-15 13:07 ` Jagan Teki
2016-02-16 1:08 ` Bin Meng
2016-02-14 20:49 ` [U-Boot] [PATCH v6 67/76] spi: Drop SPI_RX_FAST Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 68/76] configs: Enable MTD uclass in missing configs Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 69/76] configs: Drop CONFIG_SPI_FLASH_MTD Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 70/76] uclass: Replace UCLASS_SPI_FLASH with UCLASS_MTD Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 71/76] uclass: Drop UCLASS_SPI_FLASH Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 72/76] configs: Use CONFIG_SPL_SPI_NOR_SUPPORT Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 73/76] configs: Enable CONFIG_SPL_MTD_SUPPORT Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 74/76] sf: Drop entire spi-flash framework Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 75/76] MAINTAINERS: Add myself as SPI NOR maintainer Jagan Teki
2016-02-14 20:49 ` [U-Boot] [PATCH v6 76/76] configs: CONFIG_MTD_SPI_NOR_USE_4K_SECTORS Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455482955-19053-14-git-send-email-jteki@openedev.com \
--to=jteki@openedev.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox