public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: Fix gmac not working due to cpu_eth_init no longer being called
Date: Thu, 17 Mar 2016 13:21:35 +0000	[thread overview]
Message-ID: <1458220895.30744.31.camel@hellion.org.uk> (raw)
In-Reply-To: <1458219728-13910-1-git-send-email-hdegoede@redhat.com>

On Thu, 2016-03-17 at 14:02 +0100, Hans de Goede wrote:
> cpu_eth_init is no longer called for dm enabled eth drivers, this
> was causing the sunxi gmac eth controller to no longer work in u-
> boot.
> 
> This commit fixes this by moving the gpio setup to gpio_init() and by
> calling the clock, reset and pinmux setup function from s_init().
> 
> Note that the mdelay is dropped as the phy gets enabled much earlier
> now, so it is no longer needed.

Everything is DM_ETH based now, right? Which is why this final hunk is
OK?

> [...]
> @@ -79,16 +79,4 @@ int sunxi_gmac_initialize(bd_t *bis)
> ?	for (pin = SUNXI_GPA(26); pin <= SUNXI_GPA(27); pin++)
> ?		sunxi_gpio_set_cfgpin(pin, SUN6I_GPA_GMAC);
> ?#endif
> -
> -#ifdef CONFIG_DM_ETH
> -	return 0;
> -#else
> -# ifdef CONFIG_RGMII
> -	return designware_initialize(SUNXI_GMAC_BASE, PHY_INTERFACE_MODE_RGMII);
> -# elif defined CONFIG_GMII
> -	return designware_initialize(SUNXI_GMAC_BASE, PHY_INTERFACE_MODE_GMII);
> -# else
> -	return designware_initialize(SUNXI_GMAC_BASE, PHY_INTERFACE_MODE_MII);
> -# endif
> -#endif
> ?}

  reply	other threads:[~2016-03-17 13:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 13:02 [U-Boot] [PATCH] sunxi: Fix gmac not working due to cpu_eth_init no longer being called Hans de Goede
2016-03-17 13:21 ` Ian Campbell [this message]
2016-03-17 14:38   ` Hans de Goede
2016-03-17 16:27     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458220895.30744.31.camel@hellion.org.uk \
    --to=ijc+uboot@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox