From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Date: Thu, 17 Mar 2016 16:27:58 +0000 Subject: [U-Boot] [PATCH] sunxi: Fix gmac not working due to cpu_eth_init no longer being called In-Reply-To: <56EAC166.10602@redhat.com> References: <1458219728-13910-1-git-send-email-hdegoede@redhat.com> <1458220895.30744.31.camel@hellion.org.uk> <56EAC166.10602@redhat.com> Message-ID: <1458232078.30744.32.camel@hellion.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 2016-03-17 at 15:38 +0100, Hans de Goede wrote: > Hi, > > On 17-03-16 14:21, Ian Campbell wrote: > > > > On Thu, 2016-03-17 at 14:02 +0100, Hans de Goede wrote: > > > > > > cpu_eth_init is no longer called for dm enabled eth drivers, this > > > was causing the sunxi gmac eth controller to no longer work in u- > > > boot. > > > > > > This commit fixes this by moving the gpio setup to gpio_init() > > > and by > > > calling the clock, reset and pinmux setup function from s_init(). > > > > > > Note that the mdelay is dropped as the phy gets enabled much > > > earlier > > > now, so it is no longer needed. > > Everything is DM_ETH based now, right? Which is why this final hunk is > > OK? > Correct, we only do DM for eth in sunxi now, Super. Acked-by: Ian Campbell Ian.