From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] debug_uart: Remove duplicated carriage return handling
Date: Thu, 17 Mar 2016 23:59:04 -0700 [thread overview]
Message-ID: <1458284344-32149-2-git-send-email-bmeng.cn@gmail.com> (raw)
In-Reply-To: <1458284344-32149-1-git-send-email-bmeng.cn@gmail.com>
Since commit b391d74 "debug_uart: output CR along with LF", the
handling in puts() is duplicated, not to mention that it should
output carriage return before line feed.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
common/console.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/common/console.c b/common/console.c
index 6a0d11b..12293f3 100644
--- a/common/console.c
+++ b/common/console.c
@@ -515,8 +515,6 @@ void puts(const char *s)
int ch = *s++;
printch(ch);
- if (ch == '\n')
- printch('\r');
}
return;
}
--
1.8.2.1
next prev parent reply other threads:[~2016-03-18 6:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 6:59 [U-Boot] [PATCH 1/2] efi_stub: Move carriage return before line feed in putc() Bin Meng
2016-03-18 6:59 ` Bin Meng [this message]
2016-03-18 13:26 ` [U-Boot] [PATCH 2/2] debug_uart: Remove duplicated carriage return handling Tom Rini
2016-03-27 22:27 ` [U-Boot] [U-Boot, " Tom Rini
2016-03-18 13:26 ` [U-Boot] [PATCH 1/2] efi_stub: Move carriage return before line feed in putc() Tom Rini
2016-03-27 22:27 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458284344-32149-2-git-send-email-bmeng.cn@gmail.com \
--to=bmeng.cn@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox