From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] musb: sunxi: Do not allocate musb struct multiple times
Date: Tue, 05 Apr 2016 10:37:57 +0100 [thread overview]
Message-ID: <1459849077.1749.0.camel@hellion.org.uk> (raw)
In-Reply-To: <57003C11.1080301@redhat.com>
On Sat, 2016-04-02 at 23:39 +0200, Hans de Goede wrote:
> Hi,
>
> On 04/02/2016 08:57 PM, Peter Korsgaard wrote:
> >
> > >
> > > >
> > > > >
> > > > > >
> > > > > > >
> > > > > > > "Hans" == Hans de Goede <hdegoede@redhat.com> writes:
> > ? > The probe function of the musb host driver can be called
> > multiple
> > ? > times. The code assumes that it can safe the pointer to the
> > allocated
> > ? > musb struct in the driver model priv_auto_alloc data, but this
> > data
> > ? > gets free-ed on a probe failure or on removal, so we must safe
> > the
> > ? > pointer elsewhere.
> >
> > s/safe/save/ (twice).
> Thanks, fixed in my tree.
Acked-by: Ian Campbell <ijc@hellion.org.uk>
next prev parent reply other threads:[~2016-04-05 9:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 18:46 [U-Boot] [PATCH 1/3] musb: sunxi: Do not allocate musb struct multiple times Hans de Goede
2016-04-02 18:46 ` [U-Boot] [PATCH 2/3] musb: Properly call musb_stop() on probe failure Hans de Goede
2016-04-02 18:46 ` [U-Boot] [PATCH 3/3] dm: usb: Do not reprobe usb hosts on "usb tree" command Hans de Goede
2016-04-02 18:57 ` [U-Boot] [PATCH 1/3] musb: sunxi: Do not allocate musb struct multiple times Peter Korsgaard
2016-04-02 21:39 ` Hans de Goede
2016-04-05 9:37 ` Ian Campbell [this message]
2016-04-05 9:00 ` [U-Boot] [U-Boot, " Hans de Goede
2016-04-05 23:12 ` Marek Vasut
2016-04-06 12:21 ` Hans de Goede
2016-04-06 12:34 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459849077.1749.0.camel@hellion.org.uk \
--to=ijc+uboot@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox