From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Date: Tue, 05 Apr 2016 10:37:57 +0100 Subject: [U-Boot] [PATCH 1/3] musb: sunxi: Do not allocate musb struct multiple times In-Reply-To: <57003C11.1080301@redhat.com> References: <1459622771-12704-1-git-send-email-hdegoede@redhat.com> <87fuv3u9dp.fsf@dell.be.48ers.dk> <57003C11.1080301@redhat.com> Message-ID: <1459849077.1749.0.camel@hellion.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sat, 2016-04-02 at 23:39 +0200, Hans de Goede wrote: > Hi, > > On 04/02/2016 08:57 PM, Peter Korsgaard wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > "Hans" == Hans de Goede writes: > > ? > The probe function of the musb host driver can be called > > multiple > > ? > times. The code assumes that it can safe the pointer to the > > allocated > > ? > musb struct in the driver model priv_auto_alloc data, but this > > data > > ? > gets free-ed on a probe failure or on removal, so we must safe > > the > > ? > pointer elsewhere. > > > > s/safe/save/ (twice). > Thanks, fixed in my tree. Acked-by: Ian Campbell