public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] sunxi: Enable usb ports on the Sinovoip BPI M3
Date: Tue, 05 Apr 2016 11:44:44 +0100	[thread overview]
Message-ID: <1459853084.1749.10.camel@hellion.org.uk> (raw)
In-Reply-To: <57038AB8.70902@redhat.com>

On Tue, 2016-04-05 at 11:51 +0200, Hans de Goede wrote:
> Hi,
> 
> On 05-04-16 11:44, Ian Campbell wrote:
> > 
> > On Sat, 2016-04-02 at 21:10 +0200, Hans de Goede wrote:
> > > 
> > > DLDO3 is used to provide Port-D power and PD is used for the
> > > usb-hub / sata-5v enable pins. The 2.5V comes from the schematic
> > > and matches the factory image fex file.
> > Is the dts update being sync'd from the kernel?
> Erm, no actually, the A83t USB support for the kernel is not entirely
> ready, so we've some very minimal nodes in u-boot's a83t.dtsi for
> now,
> which will get replaced with the real deal when we sync in the
> future.
> 
> The only thing u-boot cares about are controller base address and
> the compatible string, and there is no discussion about those,
> which is why I merged ChenYu's .dtsi patches with the minimal nodes,
> this commit just enables these nodes in the M3 dts.

Ah, ok. Is it worth mentioning that in the commit log for clarity
(think of someone doing a resync with the kernel and getting confused
by the non-kernel bits)?

Maybe the commit message on the orignal addition makes it unnecessary?
If you think that's the case then you can keep my Ack.

Ian.

  reply	other threads:[~2016-04-05 10:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-02 19:10 [U-Boot] [PATCH 1/3] sunxi: Add INITIAL_USB_SCAN_DELAY Kconfig option Hans de Goede
2016-04-02 19:10 ` [U-Boot] [PATCH 2/3] sunxi: Set DCDC1 to 3.3V on the Sinovoip BPI M3 Hans de Goede
2016-04-05  9:42   ` Ian Campbell
2016-04-02 19:10 ` [U-Boot] [PATCH 3/3] sunxi: Enable usb ports " Hans de Goede
2016-04-05  9:44   ` Ian Campbell
2016-04-05  9:51     ` Hans de Goede
2016-04-05 10:44       ` Ian Campbell [this message]
2016-04-09 11:59         ` Hans de Goede
2016-04-05  9:42 ` [U-Boot] [PATCH 1/3] sunxi: Add INITIAL_USB_SCAN_DELAY Kconfig option Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459853084.1749.10.camel@hellion.org.uk \
    --to=ijc+uboot@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox