From: Dan Murphy <dmurphy@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [uboot] [PATCH 7/7] net: phy: dp83867: Add SGMII helper for configuration
Date: Fri, 8 Apr 2016 11:08:27 -0500 [thread overview]
Message-ID: <1460131707-8496-7-git-send-email-dmurphy@ti.com> (raw)
In-Reply-To: <1460131707-8496-1-git-send-email-dmurphy@ti.com>
The code assumed that if the interface is not RGMII configured
then it must be SGMII configured. This device has the ability
to support most of the MII interfaces. Therefore add the
helper for SGMII and only configure the device if the interface is
configured for SGMII.
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
drivers/net/phy/ti.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/ti.c b/drivers/net/phy/ti.c
index d503eef..4402c52 100644
--- a/drivers/net/phy/ti.c
+++ b/drivers/net/phy/ti.c
@@ -219,7 +219,7 @@ static int dp83867_config(struct phy_device *phydev)
(dp83867->fifo_depth << DP83867_PHYCR_FIFO_DEPTH_SHIFT));
if (ret)
goto err_out;
- } else {
+ } else if (phy_interface_is_sgmii(phydev)) {
phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR,
(BMCR_ANENABLE | BMCR_FULLDPLX | BMCR_SPEED1000));
--
2.8.0.rc3
next prev parent reply other threads:[~2016-04-08 16:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 16:08 [U-Boot] [uboot] [PATCH 1/7] drivers: net: cpsw: Add readinf of DT phy-handle node Dan Murphy
2016-04-08 16:08 ` [U-Boot] [uboot] [PATCH 2/7] net: zynq_gem: Add the passing of the " Dan Murphy
2016-04-11 5:35 ` Mugunthan V N
2016-04-11 7:09 ` Michal Simek
2016-04-08 16:08 ` [U-Boot] [uboot] [PATCH v4 3/7] net: phy: dp83867: Add device tree bindings and documentation Dan Murphy
2016-04-11 5:35 ` Mugunthan V N
2016-04-11 7:08 ` Michal Simek
2016-04-08 16:08 ` [U-Boot] [uboot] [PATCH v4 4/7] net: phy: ti: Allow the driver to be more configurable Dan Murphy
2016-04-11 5:36 ` Mugunthan V N
2016-04-11 7:08 ` Michal Simek
2016-04-11 12:01 ` Dan Murphy
2016-04-11 12:11 ` Michal Simek
2016-04-11 12:16 ` Dan Murphy
2016-04-08 16:08 ` [U-Boot] [uboot] [PATCH 5/7] net: phy: Move is_rgmii helper to phy.h Dan Murphy
2016-04-11 5:36 ` Mugunthan V N
2016-04-11 7:06 ` Michal Simek
2016-04-08 16:08 ` [U-Boot] [uboot] [PATCH 6/7] net: phy: Add phy_interface_is_sgmii " Dan Murphy
2016-04-11 5:37 ` Mugunthan V N
2016-04-11 7:06 ` Michal Simek
2016-04-08 16:08 ` Dan Murphy [this message]
2016-04-11 5:37 ` [U-Boot] [uboot] [PATCH 7/7] net: phy: dp83867: Add SGMII helper for configuration Mugunthan V N
2016-04-11 7:06 ` Michal Simek
2016-04-11 5:34 ` [U-Boot] [uboot] [PATCH 1/7] drivers: net: cpsw: Add readinf of DT phy-handle node Mugunthan V N
2016-04-11 7:11 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460131707-8496-7-git-send-email-dmurphy@ti.com \
--to=dmurphy@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox