From: Peng Fan <van.freenix@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video: ipu_common: fix build error
Date: Thu, 28 Apr 2016 10:07:53 +0800 [thread overview]
Message-ID: <1461809273-4603-1-git-send-email-van.freenix@gmail.com> (raw)
Some toolchains fail to build
"clk->rate = (u64)(clk->parent->rate * 16) / div;"
And the cast usage is wrong.
Use the following code to fix the issue,
"
do_div(parent_rate, div);
clk->rate = parent_rate;
"
Reported-by: Peter Robinson <pbrobinson@gmail.com>
Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Tom Rini <trini@konsulko.com>
Cc: Anatolij Gustschin <agust@denx.de>
Cc: Peter Robinson <pbrobinson@gmail.com>
---
Hi Peter,
Please help test this patch to see whether this fix your issue or not.
Thanks for pointing out this issue.
Thanks,
Peng.
drivers/video/ipu_common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/video/ipu_common.c b/drivers/video/ipu_common.c
index 36d4b23..5676a0f 100644
--- a/drivers/video/ipu_common.c
+++ b/drivers/video/ipu_common.c
@@ -352,7 +352,9 @@ static int ipu_pixel_clk_set_rate(struct clk *clk, unsigned long rate)
*/
__raw_writel((div / 16) << 16, DI_BS_CLKGEN1(clk->id));
- clk->rate = (u64)(clk->parent->rate * 16) / div;
+ do_div(parent_rate, div);
+
+ clk->rate = parent_rate;
return 0;
}
--
2.6.2
next reply other threads:[~2016-04-28 2:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 2:07 Peng Fan [this message]
2016-04-28 12:52 ` [U-Boot] [PATCH] video: ipu_common: fix build error Tom Rini
2016-04-28 14:20 ` Peter Robinson
2016-04-28 14:29 ` Stefano Babic
2016-04-28 14:44 ` Anatolij Gustschin
2017-09-05 2:48 ` [U-Boot] " Eric Nelson
2017-09-06 1:16 ` Peng Fan
2017-09-06 17:34 ` Eric Nelson
2017-09-07 6:01 ` Lothar Waßmann
2017-09-07 7:23 ` Eric Nelson
2017-09-05 2:49 ` Eric Nelson
2017-09-05 13:33 ` Fabio Estevam
2017-09-05 13:56 ` Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461809273-4603-1-git-send-email-van.freenix@gmail.com \
--to=van.freenix@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox