From: Scott Wood <oss@buserror.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix spelling of "occurred".
Date: Mon, 02 May 2016 14:03:08 -0500 [thread overview]
Message-ID: <1462215788.16584.3.camel@buserror.net> (raw)
In-Reply-To: <CAPnjgZ2O2_3V88h4=D23=OSzi5_0pETkNouf=cp3zzSbbCETfA@mail.gmail.com>
On Mon, 2016-05-02 at 12:57 -0600, Simon Glass wrote:
> Hi Scott,
>
> On 1 May 2016 at 17:34, Scott Wood <oss@buserror.net> wrote:
> > On Sun, 2016-05-01 at 12:55 -0600, Simon Glass wrote:
> > > Hi,
> > >
> > > On 30 April 2016 at 20:18, Vagrant Cascadian <vagrant@debian.org> wrote:
> > >
> > > Please can you add a commit message?
> >
> > I don't understand these "empty/missing commit message" remarks when
> > there's a
> > one-line changelog (in the subject). Do you seriously want the same line
> > repeated twice in the git commit, just so something shows up in the body
> > of
> > the e-mail? It's one thing if the commit warrants more than a single line
> > (though it's still not accurate to say that the changelog is completely
> > absent), but a spelling fix is about as trivial as it gets...
> > -Scott
> >
>
> It only takes a few seconds to add a commit message and I think it is
> good practice.
>
> But if you want to allow commits with no message (other than
> merge/release tag), then we should document it here:
> http://www.denx.de/wiki/U-Boot/Patches
There is a commit message. It is 'Fix spelling of "occurred"'.
And that wiki link explicitly says, "Put a detailed description after the
summary and blank line. If the summary line is sufficient to describe the
change, you can omit the blank line and detailed description."
-Scott
next prev parent reply other threads:[~2016-05-02 19:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-01 2:18 [U-Boot] [PATCH] Fix spelling of "occurred" Vagrant Cascadian
2016-05-01 18:55 ` Simon Glass
2016-05-01 23:34 ` Scott Wood
2016-05-02 18:57 ` Simon Glass
2016-05-02 19:03 ` Scott Wood [this message]
2016-05-02 19:26 ` Simon Glass
2016-05-03 4:29 ` Scott Wood
2016-05-02 23:32 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462215788.16584.3.camel@buserror.net \
--to=oss@buserror.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox