From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chin Liang See <clsee@altera.com>
Date: Wed, 4 May 2016 17:35:13 +0800
Subject: [U-Boot] [PATCH 1/7] usb: Don't init pointer to zero, but NULL
In-Reply-To: <5729A672.4020600@denx.de>
References: <1462308680-9366-1-git-send-email-marex@denx.de>
 <5729A672.4020600@denx.de>
Message-ID: <1462354513.1898.8.camel@altera.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wed, 2016-05-04 at 09:36 +0200, Stefan Roese wrote:
> On 03.05.2016 22:51, Marek Vasut wrote:
> > The pointer should always be inited to NULL, not zero (0). These
> > are
> > two different things and not necessarily equal.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Stefan Roese <sr@denx.de>
> > Cc: Stephen Warren <swarren@nvidia.com>
> > ---
> >   common/usb.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/common/usb.c b/common/usb.c
> > index 4d0de4d..63429d4 100644
> > --- a/common/usb.c
> > +++ b/common/usb.c
> > @@ -1064,7 +1064,7 @@ static int usb_prepare_device(struct
> > usb_device *dev, int addr, bool do_read,
> > 
> >   int usb_select_config(struct usb_device *dev)
> >   {
> > -	unsigned char *tmpbuf = 0;
> > +	unsigned char *tmpbuf = NULL;
> >   	int err;
> > 
> >   	err = get_descriptor_len(dev, USB_DT_DEVICE_SIZE,
> > USB_DT_DEVICE_SIZE);
> > 
> 
> Reviewed-by: Stefan Roese <sr@denx.de>
> 

Reviewed-by: Chin Liang See <clsee@altera.com>
Tested-by: Chin Liang See <clsee@altera.com>

Thanks
Chin Liang

> Thanks,
> Stefan