From: Chin Liang See <clsee@altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/7] usb: dwc2: Resend setup packet in all fail cases
Date: Wed, 4 May 2016 17:36:33 +0800 [thread overview]
Message-ID: <1462354593.1898.9.camel@altera.com> (raw)
In-Reply-To: <1462308680-9366-2-git-send-email-marex@denx.de>
On Tue, 2016-05-03 at 22:51 +0200, Marek Vasut wrote:
> The USB function can respond to a Setup packet with ACK or, in
> case it's busy, it can ignore the Setup packet. The USB function
> usually gets busy if we hammer it with Control EP transfers too
> much (ie. sending multiple Get Descriptor requests in a single
> microframe tends to trigger it on certain USB sticks). The DWC2
> controller will interpret not receiving an ACK after Setup packet
> as XACTERR. Check for this condition and if it happens, retry
> sending the Setup packet.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Stephen Warren <swarren@nvidia.com>
> ---
> drivers/usb/host/dwc2.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
Reviewed-by: Chin Liang See <clsee@altera.com>
Tested-by: Chin Liang See <clsee@altera.com>
Thanks
Chin Liang
next prev parent reply other threads:[~2016-05-04 9:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 20:51 [U-Boot] [PATCH 1/7] usb: Don't init pointer to zero, but NULL Marek Vasut
2016-05-03 20:51 ` [U-Boot] [PATCH 2/7] usb: dwc2: Resend setup packet in all fail cases Marek Vasut
2016-05-04 9:36 ` Chin Liang See [this message]
2016-05-03 20:51 ` [U-Boot] [PATCH 3/7] usb: dwc2: Throttle the setup packet resending Marek Vasut
2016-05-04 9:37 ` Chin Liang See
2016-05-04 17:08 ` Stephen Warren
2016-05-04 21:21 ` Marek Vasut
2016-05-06 18:04 ` Marek Vasut
2016-05-03 20:51 ` [U-Boot] [PATCH 4/7] usb: Wait after sending Set Configuration request Marek Vasut
2016-05-04 7:41 ` Stefan Roese
2016-05-04 9:45 ` Chin Liang See
2016-05-04 10:00 ` Stefan Roese
2016-05-04 10:24 ` Chin Liang See
2016-05-05 4:14 ` Sriram Dash
2016-05-04 10:21 ` Marek Vasut
2016-05-03 20:51 ` [U-Boot] [PATCH 5/7] usb: Assure Get Descriptor request is in separate microframe Marek Vasut
2016-05-04 8:03 ` Stefan Roese
2016-05-04 10:25 ` Marek Vasut
2016-05-04 17:10 ` Stephen Warren
2016-05-03 20:51 ` [U-Boot] [PATCH 6/7] usb: hub: Don't continue on get_port_status failure Marek Vasut
2016-05-04 8:05 ` Stefan Roese
2016-05-04 9:38 ` Chin Liang See
2016-05-03 20:51 ` [U-Boot] [PATCH 7/7] usb: hub: Increase the query delay Marek Vasut
2016-05-04 8:07 ` Stefan Roese
2016-05-04 11:39 ` Marek Vasut
2016-05-04 16:27 ` Stefan Roese
2016-05-04 17:11 ` Stephen Warren
2016-05-04 21:32 ` [U-Boot] [PATCH] " Marek Vasut
2016-05-04 21:34 ` Stephen Warren
2016-05-04 21:38 ` Marek Vasut
2016-05-04 7:36 ` [U-Boot] [PATCH 1/7] usb: Don't init pointer to zero, but NULL Stefan Roese
2016-05-04 9:35 ` Chin Liang See
2016-05-06 16:36 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462354593.1898.9.camel@altera.com \
--to=clsee@altera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox