From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chin Liang See <clsee@altera.com>
Date: Wed, 4 May 2016 17:38:03 +0800
Subject: [U-Boot] [PATCH 6/7] usb: hub: Don't continue on
	get_port_status failure
In-Reply-To: <5729AD5D.2070906@denx.de>
References: <1462308680-9366-1-git-send-email-marex@denx.de>
 <1462308680-9366-6-git-send-email-marex@denx.de> <5729AD5D.2070906@denx.de>
Message-ID: <1462354683.1898.11.camel@altera.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wed, 2016-05-04 at 10:05 +0200, Stefan Roese wrote:
> On 03.05.2016 22:51, Marek Vasut wrote:
> > The code shouldn't continue probing the port if get_port_status()
> > failed.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Stefan Roese <sr@denx.de>
> > Cc: Stephen Warren <swarren@nvidia.com>
> > ---
> >   common/usb_hub.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/common/usb_hub.c b/common/usb_hub.c
> > index 4f59802..0f39c9f 100644
> > --- a/common/usb_hub.c
> > +++ b/common/usb_hub.c
> > @@ -402,6 +402,7 @@ static int usb_scan_port(struct usb_device_scan
> > *usb_scan)
> >   			free(usb_scan);
> >   			return 0;
> >   		}
> > +		return 0;
> >   	}
> > 
> >   	portstatus = le16_to_cpu(portsts->wPortStatus);
> > 
> 
> Thanks for spotting this:
> 
> Reviewed-by: Stefan Roese <sr@denx.de>
> 

Reviewed-by: Chin Liang See <clsee@altera.com>
Tested-by: Chin Liang See <clsee@altera.com>

Thanks
Chin Liang

> Thanks,
> Stefan