From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 06/18] net: macb: Flush correct cache portion when sending
Date: Thu, 5 May 2016 07:28:10 -0600 [thread overview]
Message-ID: <1462454902-6093-7-git-send-email-sjg@chromium.org> (raw)
In-Reply-To: <1462454902-6093-1-git-send-email-sjg@chromium.org>
The end address of the cache flush must be cache-line-aligned since
otherwise (at least on ARM926-EJS) the request is ignored. When the cache
is enabled this means that packets are not sent.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Heiko Schocher <hs@denx.de>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
---
Changes in v2: None
drivers/net/macb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index f0af40c..ecdfc1b 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -280,7 +280,7 @@ static int _macb_send(struct macb_device *macb, const char *name, void *packet,
barrier();
macb_flush_ring_desc(macb, TX);
/* Do we need check paddr and length is dcache line aligned? */
- flush_dcache_range(paddr, paddr + length);
+ flush_dcache_range(paddr, paddr + ALIGN(length, ARCH_DMA_MINALIGN));
macb_writel(macb, NCR, MACB_BIT(TE) | MACB_BIT(RE) | MACB_BIT(TSTART));
/*
--
2.8.0.rc3.226.g39d4020
next prev parent reply other threads:[~2016-05-05 13:28 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 13:28 [U-Boot] [PATCH v2 00/18] at91: Convert Ethernet and LCD to driver model Simon Glass
2016-05-05 13:28 ` [U-Boot] [PATCH v2 01/18] at91: Add support for the AT91 slow clock controller Simon Glass
2016-06-12 22:01 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 02/18] arm: Allow skipping of low-level init with I-cache on Simon Glass
2016-05-05 14:07 ` Andreas Bießmann
2016-06-12 22:01 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 03/18] bootm: Align cache flush end address correctly Simon Glass
2016-05-05 14:19 ` Andreas Bießmann
2016-06-12 22:01 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 04/18] net: Handle an empty bootp extension section Simon Glass
2016-06-12 22:01 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 05/18] net: macb: Prepare for driver-model conversion Simon Glass
2016-05-05 18:31 ` Joe Hershberger
2016-05-28 22:32 ` Andreas Bießmann
2016-06-20 1:30 ` Simon Glass
2016-06-12 22:01 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-05-05 13:28 ` Simon Glass [this message]
2016-05-28 12:35 ` [U-Boot] [PATCH v2 06/18] net: macb: Flush correct cache portion when sending Andreas Bießmann
2016-06-12 22:01 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 07/18] net: macb: Convert to driver model Simon Glass
2016-05-28 22:43 ` Andreas Bießmann
2016-06-12 22:01 ` [U-Boot] [U-Boot,v2,07/18] " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 08/18] arm: at91: dts: Bring in device tree file for AT91SAM9G45 Simon Glass
2016-05-28 22:45 ` Andreas Bießmann
2016-06-12 22:01 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 09/18] arm: at91: Add a header file for the real-time clock Simon Glass
2016-05-28 12:49 ` Andreas Bießmann
2016-06-12 22:01 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 10/18] at91: Correct NAND ECC register access Simon Glass
2016-05-28 21:06 ` Andreas Bießmann
2016-06-12 22:01 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 11/18] at91: nand: Set up the ECC strength correctly Simon Glass
2016-05-28 21:12 ` Andreas Bießmann
2016-06-12 22:01 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 12/18] mtd: nand: Drop a blank line in nand_wait() Simon Glass
2016-05-28 12:53 ` Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 13/18] at91: Add driver-model GPIO devices for AT91SAM9G45 Simon Glass
2016-05-28 22:46 ` Andreas Bießmann
2016-06-12 22:01 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 14/18] at91: mtd: nand: Add dev_warn() to correct build error in driver Simon Glass
2016-05-28 23:04 ` Andreas Bießmann
2016-06-04 20:27 ` [U-Boot] [PATCH] linux/compat.h: add dev_warn() Andreas Bießmann
2016-06-10 0:35 ` Simon Glass
2016-06-12 22:01 ` [U-Boot] " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 15/18] at91: video: Prepare for driver-model conversion Simon Glass
2016-06-04 20:08 ` Andreas Bießmann
2016-06-12 22:01 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 16/18] at91: video: Support driver-model for the LCD driver Simon Glass
2016-06-04 20:11 ` Andreas Bießmann
2016-06-12 22:01 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 17/18] fdt: Correct return value in fdtdec_decode_display_timing() Simon Glass
2016-06-04 20:14 ` Andreas Bießmann
2016-06-12 22:01 ` [U-Boot] [U-Boot, v2, " Andreas Bießmann
2016-05-05 13:28 ` [U-Boot] [PATCH v2 18/18] arm: at91: Add support for gurnard Simon Glass
2016-06-04 20:31 ` Andreas Bießmann
2016-06-12 22:01 ` [U-Boot] [U-Boot,v2,18/18] " Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462454902-6093-7-git-send-email-sjg@chromium.org \
--to=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox