From: Ian Campbell <ijc+uboot@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: Enable a bunch of commands by default on sunxi
Date: Mon, 16 May 2016 10:12:48 +0100 [thread overview]
Message-ID: <1463389968.1876.24.camel@hellion.org.uk> (raw)
In-Reply-To: <1463315251-420-1-git-send-email-hdegoede@redhat.com>
On Sun, 2016-05-15 at 14:27 +0200, Hans de Goede wrote:
> Recently a set of CONFIG_CMD_FOO defines was moved from being defined
> in config_distro_defaults to Kconfig, and added to all sunxi defconfigs
> to compensate.
I wonder if some of them ought to be "default y" globally, since they
seem like they should be enabled on most boards by default, but that's
outside my balliwick. So as far as this sunxi change goes:
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Ian Campbell <ijc@hellion.org.uk>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 6b65d8e..491577f 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -538,7 +538,16 @@ config TARGET_CM_T43
> ?
> ?config ARCH_SUNXI
> ? bool "Support sunxi (Allwinner) SoCs"
> + select CMD_BOOTZ
> + select CMD_DHCP
> + select CMD_EXT2
> + select CMD_EXT4
> + select CMD_FAT
> + select CMD_FS_GENERIC
> ? select CMD_GPIO
> + select CMD_MII
> + select CMD_MMC if MMC
> + select CMD_PING
> ? select CMD_USB
> ? select DM
> ? select DM_ETH
> @@ -546,6 +555,7 @@ config ARCH_SUNXI
> ? select DM_KEYBOARD
> ? select DM_SERIAL
> ? select DM_USB
> + select HUSH_PARSER
> ? select OF_BOARD_SETUP
> ? select OF_CONTROL
> ? select OF_SEPARATE
> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
> index 059e914..c1ae6f5 100644
> --- a/board/sunxi/Kconfig
> +++ b/board/sunxi/Kconfig
> @@ -368,6 +368,7 @@ config I2C0_ENABLE
> ? bool "Enable I2C/TWI controller 0"
> ? default y if MACH_SUN4I || MACH_SUN5I || MACH_SUN7I
> ? default n if MACH_SUN6I || MACH_SUN8I
> + select CMD_I2C
> ? ---help---
> ? This allows enabling I2C/TWI controller 0 by muxing its pins, enabling
> ? its clock and setting up the bus. This is especially useful on devices
> @@ -377,12 +378,14 @@ config I2C0_ENABLE
> ?config I2C1_ENABLE
> ? bool "Enable I2C/TWI controller 1"
> ? default n
> + select CMD_I2C
> ? ---help---
> ? See I2C0_ENABLE help text.
> ?
> ?config I2C2_ENABLE
> ? bool "Enable I2C/TWI controller 2"
> ? default n
> + select CMD_I2C
> ? ---help---
> ? See I2C0_ENABLE help text.
> ?
> @@ -390,6 +393,7 @@ if MACH_SUN6I || MACH_SUN7I
> ?config I2C3_ENABLE
> ? bool "Enable I2C/TWI controller 3"
> ? default n
> + select CMD_I2C
> ? ---help---
> ? See I2C0_ENABLE help text.
> ?endif
> @@ -399,6 +403,7 @@ config R_I2C_ENABLE
> ? bool "Enable the PRCM I2C/TWI controller"
> ? # This is used for the pmic on H3
> ? default y if SY8106A_POWER
> + select CMD_I2C
> ? ---help---
> ? Set this to y to enable the I2C controller which is part of the PRCM.
> ?endif
> @@ -407,6 +412,7 @@ if MACH_SUN7I
> ?config I2C4_ENABLE
> ? bool "Enable I2C/TWI controller 4"
> ? default n
> + select CMD_I2C
> ? ---help---
> ? See I2C0_ENABLE help text.
> ?endif
> @@ -535,6 +541,7 @@ config VIDEO_LCD_PANEL_I2C
> ? bool "LCD panel needs to be configured via i2c"
> ? depends on VIDEO
> ? default n
> + select CMD_I2C
> ? ---help---
> ? Say y here if the LCD panel needs to be configured via i2c. This
> ? will add a bitbang i2c controller using gpios to talk to the LCD.
prev parent reply other threads:[~2016-05-16 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-15 12:27 [U-Boot] [PATCH] sunxi: Enable a bunch of commands by default on sunxi Hans de Goede
2016-05-16 9:12 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463389968.1876.24.camel@hellion.org.uk \
--to=ijc+uboot@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox