From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Thu, 09 Jun 2016 12:10:15 -0500 Subject: [U-Boot] [PATCH v2 1/2] nand: nand torture: follow sync with linux v4.6 In-Reply-To: References: <1465299980-23195-1-git-send-email-max.krummenacher@toradex.com> Message-ID: <1465492215.22191.122.camel@buserror.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 2016-06-09 at 10:35 +0200, Max Krummenacher wrote: > Hi Scott > > 2016-06-09 1:47 GMT+02:00 Scott Wood : > > On 06/07/2016 06:47 AM, Max Krummenacher wrote: > > > follow parameter name change (nand to mtd) to fix compiler error. > > > > > > Signed-off-by: Max Krummenacher > > > > > > --- > > > > > > Changes in v2: > > > - Patch v1 1/1 went into master, but Scott's patch series syncing > > > with kernel v4.6 introduced an additional compile time error. > > > > > > drivers/mtd/nand/nand_util.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/mtd/nand/nand_util.c b/drivers/mtd/nand/nand_util.c > > > index 5bba66a..e8bcc34 100644 > > > --- a/drivers/mtd/nand/nand_util.c > > > +++ b/drivers/mtd/nand/nand_util.c > > > @@ -820,7 +820,7 @@ int nand_torture(struct mtd_info *mtd, loff_t > > > offset) > > > { > > > u_char patterns[] = {0xa5, 0x5a, 0x00}; > > > struct erase_info instr = { > > > - .mtd = nand, > > > + .mtd = mtd, > > > .addr = offset, > > > .len = mtd->erasesize, > > > }; > > > > This got missed because no boards enable CONFIG_CMD_NAND_TORTURE. If > > you use this option could you enable it in the relevant board? > > I believe this makes option makes only sense if you do HW bringup or > have issues with > your NAND driver. (Which I currently have with an i.MX 7 design) > So likely one would not want to enable this for production code. That's why I suggested the alternative of adding one or more targets aimed at build coverage. > On the other hand people switching on the option should be able to fix > whatever issue > arises. > > And, considering that it was broken since January 2013 > (dfe64e2c89731a3f9950d7acd8681b68df2bae03) it can not be that important. This patch fixes a breakage that was merged within the past week. What was broken by the 2013 sync? -Scott