public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Alexey Brodkin <alexey.brodkin@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH RESEND 2/2 v2] lib: Add hexdump
Date: Fri, 10 Jun 2016 23:49:03 +0300	[thread overview]
Message-ID: <1465591743.2815.3.camel@gmail.com> (raw)
In-Reply-To: <20160610192234.GD11619@bill-the-cat>

Hi Tom,

On Fri, 2016-06-10 at 15:22 -0400, Tom Rini wrote:
> On Fri, Jun 10, 2016 at 03:42:31PM +0300, Alexey Brodkin wrote:
> 
> > 
> > Often during debugging session it's very interesting to see
> > what data we were dealing with. For example what we write or read
> > to/from memory or peripherals.
> > 
> > This change introduces functions that allow to dump binary
> > data with one simple function invocation like:
> Reviewed-by: Tom Rini <trini@konsulko.com>
> 
> ... except adding to <common.h>.??Do we really need it placed in there?
> 

Rationale behind it was to keep a minimal amount of changes.
I mean those mentioned existing "users" of hexdump will require
explicit mention of that new header which I wanted to escape.

Still I may agree with proposal to remove hexdump.h from common.h...
if we're going to accept this patch at all [in any form]...

-Alexey

  reply	other threads:[~2016-06-10 20:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10 12:42 [U-Boot] [PATCH RESEND 0/2 v2] Introduce hexdump Alexey Brodkin
2016-06-10 12:42 ` [U-Boot] [PATCH RESEND 1/2 v2] linux-compat: Use original kern_levels.h for kernel debug levels Alexey Brodkin
2016-06-10 19:20   ` Tom Rini
2016-06-13 12:36     ` Alexey Brodkin
2016-06-13 14:13       ` Tom Rini
2016-06-10 12:42 ` [U-Boot] [PATCH RESEND 2/2 v2] lib: Add hexdump Alexey Brodkin
2016-06-10 15:31   ` Langer, Thomas
2016-06-10 19:37     ` Tom Rini
2016-06-10 20:51       ` Alexey Brodkin
2016-06-10 21:39         ` Tom Rini
2016-06-10 21:58           ` Алексей Бродкин
2016-06-10 22:18             ` Tom Rini
2016-06-10 19:22   ` Tom Rini
2016-06-10 20:49     ` Alexey Brodkin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-06-10 15:39 Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465591743.2815.3.camel@gmail.com \
    --to=alexey.brodkin@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox