From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexey Brodkin <alexey.brodkin@gmail.com>
Date: Fri, 10 Jun 2016 23:49:03 +0300
Subject: [U-Boot] [PATCH RESEND 2/2 v2] lib: Add hexdump
In-Reply-To: <20160610192234.GD11619@bill-the-cat>
References: <1465562551-6529-1-git-send-email-abrodkin@synopsys.com>
 <1465562551-6529-3-git-send-email-abrodkin@synopsys.com>
 <20160610192234.GD11619@bill-the-cat>
Message-ID: <1465591743.2815.3.camel@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tom,

On Fri, 2016-06-10 at 15:22 -0400, Tom Rini wrote:
> On Fri, Jun 10, 2016 at 03:42:31PM +0300, Alexey Brodkin wrote:
> 
> > 
> > Often during debugging session it's very interesting to see
> > what data we were dealing with. For example what we write or read
> > to/from memory or peripherals.
> > 
> > This change introduces functions that allow to dump binary
> > data with one simple function invocation like:
> Reviewed-by: Tom Rini <trini@konsulko.com>
> 
> ... except adding to <common.h>.??Do we really need it placed in there?
> 

Rationale behind it was to keep a minimal amount of changes.
I mean those mentioned existing "users" of hexdump will require
explicit mention of that new header which I wanted to escape.

Still I may agree with proposal to remove hexdump.h from common.h...
if we're going to accept this patch at all [in any form]...

-Alexey