From: "Andreas Bießmann" <andreas@biessmann.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] gpio: at91: Fix pullup/pulldown configuration on PIO3
Date: Mon, 13 Jun 2016 00:00:47 +0200 [thread overview]
Message-ID: <1465768847-6745-1-git-send-email-andreas@biessmann.org> (raw)
In-Reply-To: <1462395923-5035-1-git-send-email-marex@denx.de> (from Marek Vasut on Wed, 4 May 2016 23:05:23 +0200)
Dear Marek Vasut,
Marek Vasut <marex@denx.de> writes:
>On systems with PIO3 (SAMA5D3/D4/..), the pullup and pulldown configuration
>is mutualy exclusive. This patch assures that the opposite pull resistor gets
>disabled before the requested pull resistor is enabled. This changes behavior
>of at91_set_pio_pulldown() such that the pullup is only disabled if pulldown
>is to be enabled. This changes behavior of at91_set_pio_pullup() such that
>the pulldown is only disabled if pullup is to be enabled.
>
>Signed-off-by: Marek Vasut <marex@denx.de>
>Cc: Andreas Bie?mann <andreas.devel@googlemail.com>
>Cc: Josh Wu <josh.wu@atmel.com>
>Cc: Simon Glass <sjg@chromium.org>
>Reviewed-by: Andreas Bie?mann <andreas@biessmann.org>
>---
> drivers/gpio/at91_gpio.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
applied to u-boot-atmel/master, thanks!
Best regards,
Andreas Bie?mann
prev parent reply other threads:[~2016-06-12 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 21:05 [U-Boot] [PATCH] gpio: at91: Fix pullup/pulldown configuration on PIO3 Marek Vasut
2016-05-28 22:15 ` Andreas Bießmann
2016-06-12 20:20 ` Andreas Bießmann
2016-06-12 22:00 ` Andreas Bießmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465768847-6745-1-git-send-email-andreas@biessmann.org \
--to=andreas@biessmann.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox