From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Date: Mon, 13 Jun 2016 12:36:04 +0000 Subject: [U-Boot] [PATCH RESEND 1/2 v2] linux-compat: Use original kern_levels.h for kernel debug levels In-Reply-To: <20160610192048.GC11619@bill-the-cat> References: <1465562551-6529-1-git-send-email-abrodkin@synopsys.com> <1465562551-6529-2-git-send-email-abrodkin@synopsys.com> <20160610192048.GC11619@bill-the-cat> Message-ID: <1465821314.4130.17.camel@synopsys.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, On Fri, 2016-06-10 at 15:20 -0400, Tom Rini wrote: > On Fri, Jun 10, 2016 at 03:42:30PM +0300, Alexey Brodkin wrote: > > > > Even currently in U-Boot we don't really use kernel debug levels > > we do have quite a lot of code that was copy-pasted from Linux kernel > > and so contains symbols like KERN_DEBUG and alike. > > > > We used to just define those symbols which is fine if it is used in > > constructions like: > > ----------------->8-------------- > > ????printk(KERN_DEBUG "My debug message"); > > ----------------->8-------------- > > > > But in other places where the symbol gets passed as a separate > > argument (which we also have but luckily all of them are intself > > dummy stubs in U-Boot) that won't work. > > > > Now as a preparation to introduction of a real implementation of > > print_hex_dump() we need those symbols to be defined as something real > > so we're taking them as they are from Linux kernel. > > Contents are fine but you need to say what version of the kernel you get > it from. This is taken from 4.7-rc2. Given print_hex_dump() requires rework in a sense that we want to replace existing print_buffer() with it maybe we apply this patch because it has no dependencies on anything else? If you want I may resend it with added info about kernel version used for copy, or alternatively you may fixup it on patch application. -Alexey