From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] arc: axs103 compile broken ?
Date: Tue, 14 Jun 2016 07:15:04 +0000 [thread overview]
Message-ID: <1465888453.4130.47.camel@synopsys.com> (raw)
In-Reply-To: <575F912A.7070506@denx.de>
Hi Heiko,
On Tue, 2016-06-14 at 07:07 +0200, Heiko Schocher wrote:
> Hello Sjoerd,
>
> as I just write a tbot testcase, which checks patches, which moves
> a config option to Kconfig, I tested also to compile arc boards, and
> the first try immediately failed with:
>
> pollux:u-boot-dxr2 hs [master] $ make axs103_defconfig
> ???HOSTCC??scripts/basic/fixdep
> ???HOSTCC??scripts/kconfig/conf.o
> ???SHIPPED scripts/kconfig/zconf.tab.c
> ???SHIPPED scripts/kconfig/zconf.lex.c
> ???SHIPPED scripts/kconfig/zconf.hash.c
> ???HOSTCC??scripts/kconfig/zconf.tab.o
> ???HOSTLD??scripts/kconfig/conf
> #
> # configuration written to .config
> #
> pollux:u-boot-dxr2 hs [master] $ make -s -j8 all
> In file included from drivers/net/designware.c:21:0:
> drivers/net/designware.h:11:22: fatal error: asm/gpio.h: Datei oder Verzeichnis nicht gefunden
> ? #include <asm/gpio.h>
> ???????????????????????^
> compilation terminated.
> scripts/Makefile.build:280: recipe for target 'drivers/net/designware.o' failed
> make[1]: *** [drivers/net/designware.o] Error 1
> Makefile:1208: recipe for target 'drivers/net' failed
> make: *** [drivers/net] Error 2
> make: *** Warte auf noch nicht beendete Prozesse...
> pollux:u-boot-dxr2 hs [master] $
>
> looking into the git history of drivers/net/designware.c it seems
> to me, that the commit:
>
> commit 90b7fc924adf "net: designware: support phy reset device-tree bindings"
>
> added the missing include.
>
> $ find arch/arc/include/asm/ -name gpio.h
> $
>
> I used the toolchain from:
> https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/releases/tag/arc-2015.12
>
> Some ideas? May I did something wrong?
The problem happens because for ARC we don't have "gpio.h" in "arch/arc/include/asm".
That's because we never needed one and I don't know what to put there except inclusion of
"include/asm-generic/gpio.h".
Indeed I or anybody else may send a patch to address that missing header for ARC.
But for me it looks like improper solution - why multiply substances?
We may instead just include headers from "asm-generic" by default and get rid of all
senseless dummy arch/X/include/asm instances.
-Alexey
next prev parent reply other threads:[~2016-06-14 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 5:07 [U-Boot] arc: axs103 compile broken ? Heiko Schocher
2016-06-14 7:15 ` Alexey Brodkin [this message]
2016-06-16 0:39 ` Simon Glass
2016-06-16 6:36 ` Alexey Brodkin
2016-06-17 3:52 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465888453.4130.47.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox