public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: Add defconfig for Olinuxino Lime 2 EMMC version
Date: Wed, 15 Jun 2016 09:17:53 +0100	[thread overview]
Message-ID: <1465978673.22752.46.camel@hellion.org.uk> (raw)
In-Reply-To: <1465961365-90707-1-git-send-email-manu@freebsd.org>

On Wed, 2016-06-15 at 05:29 +0200, Emmanuel Vadot wrote:

Please include a short description of the board, in this case
explaining the distinction (and defconfig differences) from the non-
EMMC version would be useful.

Have a look at some of the previous patches which add defconfig (e.g.
those from Hans) for some examples of best practice.

> Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> ---
> ?configs/A20-OLinuXino-Lime2-emmc_defconfig | 21 +++++++++++++++++++++

This patch should also touch board/sunxi/MAINTAINERS, to add an entry
with your name for this board.?

> +CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-olinuxino-lime2-emmc"

This file doesn't appear to be in the u-boot tree already so usually we
would import the upstream version as part of this patch.

In fact I'm not sure how this patch builds without it, we configure u-
boot itself via DM for at least some subsystems, which requires it to
be present a build time to be concatenated onto the basic image.

Ian.

      reply	other threads:[~2016-06-15  8:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15  3:29 [U-Boot] [PATCH] sunxi: Add defconfig for Olinuxino Lime 2 EMMC version Emmanuel Vadot
2016-06-15  8:17 ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465978673.22752.46.camel@hellion.org.uk \
    --to=ijc@hellion.org.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox