From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Date: Wed, 15 Jun 2016 09:17:53 +0100 Subject: [U-Boot] [PATCH] sunxi: Add defconfig for Olinuxino Lime 2 EMMC version In-Reply-To: <1465961365-90707-1-git-send-email-manu@freebsd.org> References: <1465961365-90707-1-git-send-email-manu@freebsd.org> Message-ID: <1465978673.22752.46.camel@hellion.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 2016-06-15 at 05:29 +0200, Emmanuel Vadot wrote: Please include a short description of the board, in this case explaining the distinction (and defconfig differences) from the non- EMMC version would be useful. Have a look at some of the previous patches which add defconfig (e.g. those from Hans) for some examples of best practice. > Signed-off-by: Emmanuel Vadot > --- > ?configs/A20-OLinuXino-Lime2-emmc_defconfig | 21 +++++++++++++++++++++ This patch should also touch board/sunxi/MAINTAINERS, to add an entry with your name for this board.? > +CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-olinuxino-lime2-emmc" This file doesn't appear to be in the u-boot tree already so usually we would import the upstream version as part of this patch. In fact I'm not sure how this patch builds without it, we configure u- boot itself via DM for at least some subsystems, which requires it to be present a build time to be concatenated onto the basic image. Ian.