public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot]  [PATCH] marvell: add support for Synology DS109 board
@ 2016-06-18 11:25 Walter Schweizer
  2016-08-09  7:56 ` Stefan Roese
  0 siblings, 1 reply; 2+ messages in thread
From: Walter Schweizer @ 2016-06-18 11:25 UTC (permalink / raw)
  To: u-boot



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] marvell: add support for Synology DS109 board
  2016-06-18 11:25 [U-Boot] [PATCH] marvell: add support for Synology DS109 board Walter Schweizer
@ 2016-08-09  7:56 ` Stefan Roese
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Roese @ 2016-08-09  7:56 UTC (permalink / raw)
  To: u-boot

Hi Walter,

sorry for the late review.

On 18.06.2016 13:25, Walter Schweizer wrote:
> From 842431a0cc2acb336f5c57a3ca822ba0673e712d Mon Sep 17 00:00:00 2001
> From: Walter Schweizer <swwa@users.sourceforge.net>
> Date: Sat, 18 Jun 2016 12:56:37 +0200
> Subject: [PATCH] add support for Synology DS109 board
>
> Synology DS109 is based on MV88F6281. The code
> is based on Dreamplug code with modificatons
> from Synologys open source repository.
>
> Signed-off-by: Walter Schweizer <swwa@users.sourceforge.net>
> ---
>
>  arch/arm/mach-kirkwood/Kconfig    |   4 +
>  board/Synology/ds109/Kconfig      |  12 +++
>  board/Synology/ds109/Makefile     |   9 ++
>  board/Synology/ds109/ds109.c      | 169
> ++++++++++++++++++++++++++++++++++++++
>  board/Synology/ds109/ds109.h      |  44 ++++++++++
>  board/Synology/ds109/kwbimage.cfg | 147
> +++++++++++++++++++++++++++++++++

Your patch seems to have some line wraps included. Please fix this
in v2.

>  board/Synology/ds109/openocd.cfg  | 115 ++++++++++++++++++++++++++
>  configs/ds109_defconfig           |  16 ++++
>  include/configs/ds109.h           | 118 ++++++++++++++++++++++++++
>  9 files changed, 634 insertions(+)
>  create mode 100644 board/Synology/ds109/Kconfig
>  create mode 100644 board/Synology/ds109/Makefile
>  create mode 100644 board/Synology/ds109/ds109.c
>  create mode 100644 board/Synology/ds109/ds109.h
>  create mode 100644 board/Synology/ds109/kwbimage.cfg
>  create mode 100644 board/Synology/ds109/openocd.cfg
>  create mode 100644 configs/ds109_defconfig
>  create mode 100644 include/configs/ds109.h

MATAINERS file missing.

Please check in v2 that your patch passes checkpatch without
errors. There seem to be many whitespace errors.

Thanks,
Stefan

Viele Gr??e,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-09  7:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-18 11:25 [U-Boot] [PATCH] marvell: add support for Synology DS109 board Walter Schweizer
2016-08-09  7:56 ` Stefan Roese

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox