From: Scott Wood <oss@buserror.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH v3 2/4] mtd: fix compiler warnings
Date: Tue, 28 Jun 2016 20:17:57 -0500 [thread overview]
Message-ID: <1467163077.32358.4.camel@buserror.net> (raw)
In-Reply-To: <1457822887-32123-2-git-send-email-srae@broadcom.com>
On Sat, 2016-03-12 at 14:48 -0800, Steve Rae wrote:
> - add missing declaration
> - update debug output format specifiers
>
> Signed-off-by: Steve Rae <srae@broadcom.com>
> ---
> the checkpatch warning:
> ? warning: cmd/mtdparts.c,1494: quoted string split across lines
> is for the existing code; it is not introduced with this change...
>
> Changes in v3: None
> Changes in v2: None
Why is this an RFC patch? ?It seems like an attempt to fix straightforward
problems, unrelated to the iproc driver.
> ?
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index 9da77ec..9c36f02 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -495,5 +495,13 @@ int mtd_arg_off(const char *arg, int *idx, loff_t *off,
> loff_t *size,
> ?int mtd_arg_off_size(int argc, char *const argv[], int *idx, loff_t *off,
> ? ?????loff_t *size, loff_t *maxsize, int devtype,
> ? ?????uint64_t chipsize);
> +
> +#ifdef CONFIG_CMD_MTDPARTS_SPREAD
> +/* drivers/mtd/mtdcore.c */
> +void mtd_get_len_incl_bad(struct mtd_info *mtd, uint64_t offset,
> + ??const uint64_t length, uint64_t *len_incl_bad,
> + ??int *truncated);
> +#endif /* CONFIG_CMD_MTDPARTS_SPREAD */
Don't ifdef prototypes.
-Scott
next prev parent reply other threads:[~2016-06-29 1:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-12 22:48 [U-Boot] [RFC PATCH v3 1/4] arm: iproc: add NAND driver Steve Rae
2016-03-12 22:48 ` [U-Boot] [RFC PATCH v3 2/4] mtd: fix compiler warnings Steve Rae
2016-06-29 1:17 ` Scott Wood [this message]
2016-06-29 20:47 ` Steve Rae
2016-03-12 22:48 ` [U-Boot] [RFC PATCH v3 3/4] arm: bcm: enable MTD support Steve Rae
2016-03-12 22:48 ` [U-Boot] [RFC PATCH v3 4/4] arm: bcm: configure NAND device and environment Steve Rae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467163077.32358.4.camel@buserror.net \
--to=oss@buserror.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox