From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ijc+uboot@hellion.org.uk>
Date: Sun, 10 Jul 2016 09:15:20 +0100
Subject: [U-Boot] [PATCH v2] sunxi: Add support for multiple
	ethadrr-esses
In-Reply-To: <1468069935-1212-1-git-send-email-hdegoede@redhat.com>
References: <1468069935-1212-1-git-send-email-hdegoede@redhat.com>
Message-ID: <1468138520.10653.2.camel@hellion.org.uk>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sat, 2016-07-09 at 15:12 +0200, Hans de Goede wrote:
> Currently we fill ethaddr with a fixed unique address based on the
> SoCs
> serial (from the sid) to make sure that boards which use the
> integrated
> emac / gmac get a fixed mac rather then a random one.
> 
> On some boards the wifi does not come with a fixed mac either, so we
> need
> to also set eth1addr.
> 
> This commit changes the ethaddr setting code to check for ethernet%d
> aliases (as fdt_fixup_ethernet does) and set an ethaddr variable for
> all present aliases.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Ian Campbell <ijc@hellion.org.uk>

> [...]
> +static void setup_environment(const void *fdt)

It might be worth adding a commit to this function noting that it must
remain idempotent.

Ian.