From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Date: Mon, 11 Jul 2016 14:08:31 +0100 Subject: [U-Boot] [PATCH v2] sunxi: Add support for multiple ethadrr-esses In-Reply-To: <29306da6-98d2-e130-f08d-c0631b77cce1@redhat.com> References: <1468069935-1212-1-git-send-email-hdegoede@redhat.com> <1468138520.10653.2.camel@hellion.org.uk> <29306da6-98d2-e130-f08d-c0631b77cce1@redhat.com> Message-ID: <1468242511.1985.69.camel@hellion.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 2016-07-11 at 11:02 +0200, Hans de Goede wrote: > > On Sat, 2016-07-09 at 15:12 +0200, Hans de Goede wrote: > > > > > > [...] > > > +static void setup_environment(const void *fdt) > > > > It might be worth adding a commit to this function noting that it > > must > > remain idempotent. > > Done, although I avoided the use of the word idempotent, I had to google > it to make sure it meant what I thought it meant, so using a simpler > description for us non native Enlgish speakers seemed better :) Fair enough. Ian