From: David Saada <David.Saada@ecitele.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Possible TSEC Ethernet driver patch
Date: Tue, 8 Jan 2008 08:48:07 -0800 (PST) [thread overview]
Message-ID: <14693344.post@talk.nabble.com> (raw)
In-Reply-To: <36D7B34A3A79F84F82FA0C154F299F25065C2E0D@E03MVX1-UKDY.domain1.systemhost.net>
Michael,
This would certainly be useful. In fact I thought of doing so myself as it
bothered my as well...
Furthermore, I submitted a patch couple of days ago, which added (among the
rest) MII command support to the UEC driver (basically a copy from the TSEC
code). I guess this kind of patch should go there too.
If you plan to submit this patch please inform - otherwise I'll do it myself
(I think its quite a simple one).
Regards,
David.
michael.firth wrote:
>
> While debugging a board recently I found that the MDIO (mii) command
> support in the TSEC Ethernet driver is somewhat unhelpful.
>
> Currently, even though there is a comment in the code that "For now,
> only TSEC1 (index 0) has access to the PHYs, so all of the entries have
> '0'", all MDIO commands are processed by searching for a TSEC instance
> that has the requested MDIO address associated with it, and then using
> that instance to run the command, even though, because of the
> aforementioned comment, all instances process MDIO commands through the
> same port.
>
> This means that it is only possible to communicate with MDIO addresses
> that have a TSEC instance associated with them, even though the hardware
> is capable of accessing any address. It also means that there is a list
> search that isn't needed.
>
> I have patched the 1.3.1 U-Boot code to remove this search, and to
> interrogate the requested PHY directly. This means that it is possible
> to directly access all 32 PHY addresses.
>
> Is this a change that would be more generally useful to the U-Boot
> community, and, if so, how should I submit a more general patch for
> this?
>
> Michael
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
>
>
--
View this message in context: http://www.nabble.com/Possible-TSEC-Ethernet-driver-patch-tp14692943p14693344.html
Sent from the Uboot - Users mailing list archive at Nabble.com.
prev parent reply other threads:[~2008-01-08 16:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 16:18 [U-Boot-Users] Possible TSEC Ethernet driver patch michael.firth at bt.com
2008-01-08 16:42 ` Ben Warren
2008-01-09 20:26 ` [U-Boot-Users] TSEC Ethernet driver patch - RFC michael.firth at bt.com
2008-01-15 9:59 ` michael.firth at bt.com
2008-01-15 13:03 ` David Saada
2008-01-15 15:36 ` Ben Warren
2008-01-15 16:56 ` Andy Fleming
2008-01-15 21:14 ` michael.firth at bt.com
2008-01-16 3:48 ` Ben Warren
2008-01-08 16:48 ` David Saada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14693344.post@talk.nabble.com \
--to=david.saada@ecitele.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox