From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Ziswiler Date: Wed, 3 Aug 2016 15:23:30 +0000 Subject: [U-Boot] [PATCH] net: asix: Fix ASIX 88772B with driver model In-Reply-To: <16d1be92-f2b8-cb63-a4c0-e80a0a59eb1d@denx.de> References: <20160803053254.7077-1-alban.bedel@avionic-design.de> <20160803114625.5bbc742d@avionic-0020> <16d1be92-f2b8-cb63-a4c0-e80a0a59eb1d@denx.de> Message-ID: <1470237811.3331.18.camel@toradex.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 2016-08-03 at 15:51 +0200, Marek Vasut wrote: > On 08/03/2016 11:46 AM, Alban Bedel wrote: > > > > On Wed, 3 Aug 2016 09:00:42 +0200 > > Marek Vasut wrote: > > > > > > > > On 08/03/2016 07:32 AM, Alban Bedel wrote: > > > > > > > > Commit 147271209a9d ("net: asix: fix operation without eeprom") > > > > added a special handling for ASIX 88772B that enable another > > > > type of header. This break the driver in DM mode as the extra > > > > handling > > > > needed in the receive path is missing. > > > So add the extra handling ? > > I can do that too, but I though u-boot preferred to avoid useless > > code. > Yes, if it is useless. > > > > > > > > > > > > > > However this new header mode is not required and only seems to > > > > increase the code complexity, so this patch revert this part of > > > > commit 147271209a9d. > > > Why is it not required ? > > It works fine without, since 2012. In fact this change is not even > > mentioned in the log of commit 147271209a9d, so I really don't know > > why > > it was added in the first place. As can be seen in the revert all > > it > > does is adding 2 bytes to the USB packets that are then just > > skipped. > > Seems pretty useless to me. > I would like to get some feedback on this from Marcel, since he added > this stuff. Yes, sorry. I just came back from vacation and started looking into it now. As far as I remember on our hardware without this Ethernet did not quite work reliably. This also means that with driver model so far it does not work for us which I fed back to Simon once but so far this has not been resolved. That fix came from some early U-Boot work done by Antmicro way back and I am missing some of the history. Cheers Marcel > > Alban