public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jagan Teki <jteki@openedev.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/6] sf: Move flags macro's to spi_flash_params{} members
Date: Mon,  8 Aug 2016 19:31:41 +0530	[thread overview]
Message-ID: <1470664901-17143-6-git-send-email-jteki@openedev.com> (raw)
In-Reply-To: <1470664901-17143-1-git-send-email-jteki@openedev.com>

This patch moves flags macro's to respective member position on
spi_flash_params{}, for better readabilty and finding the
respective member macro's easily.

Signed-off-by: Jagan Teki <jteki@openedev.com>
---
 drivers/mtd/spi/sf_internal.h | 23 ++++++++++-------------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/drivers/mtd/spi/sf_internal.h b/drivers/mtd/spi/sf_internal.h
index 1301e48..e5c38bf 100644
--- a/drivers/mtd/spi/sf_internal.h
+++ b/drivers/mtd/spi/sf_internal.h
@@ -20,19 +20,6 @@ enum spi_dual_flash {
 	SF_DUAL_PARALLEL_FLASH	= BIT(1),
 };
 
-/* sf param flags */
-enum {
-	SECT_4K		= BIT(0),
-	E_FSR		= BIT(1),
-	SST_WR		= BIT(2),
-	WR_QPP		= BIT(3),
-	RD_QUAD		= BIT(4),
-	RD_DUAL		= BIT(5),
-	RD_QUADIO	= BIT(6),
-	RD_DUALIO	= BIT(7),
-};
-#define RD_FULL		RD_QUAD | RD_DUAL | RD_QUADIO | RD_DUALIO
-
 enum spi_nor_option_flags {
 	SNOR_F_SST_WR		= BIT(0),
 	SNOR_F_USE_FSR		= BIT(1),
@@ -133,7 +120,17 @@ struct spi_flash_params {
 	u16 ext_jedec;
 	u32 sector_size;
 	u32 nr_sectors;
+
 	u16 flags;
+#define SECT_4K 		BIT(0)
+#define E_FSR			BIT(1)
+#define SST_WR			BIT(2)
+#define WR_QPP			BIT(3)
+#define RD_QUAD 		BIT(4)
+#define RD_DUAL 		BIT(5)
+#define RD_QUADIO		BIT(6)
+#define RD_DUALIO		BIT(7)
+#define RD_FULL 		(RD_QUAD | RD_DUAL | RD_QUADIO | RD_DUALIO)
 };
 
 extern const struct spi_flash_params spi_flash_params_table[];
-- 
2.7.4

      parent reply	other threads:[~2016-08-08 14:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-08 14:01 [U-Boot] [PATCH 1/6] sf: Simplify fastest read cmd code Jagan Teki
2016-08-08 14:01 ` [U-Boot] [PATCH 2/6] sf: Remove e_rd_cmd from param table Jagan Teki
2016-08-08 14:01 ` [U-Boot] [PATCH 3/6] spi: Use mode for rx mode flags Jagan Teki
2016-08-08 14:01 ` [U-Boot] [PATCH 4/6] sf: Remove SECT_32K Jagan Teki
2016-08-08 14:01 ` [U-Boot] [PATCH 5/6] sf: Add CONFIG_SPI_FLASH_USE_4K_SECTORS in spi_flash Jagan Teki
2016-08-08 14:01 ` Jagan Teki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470664901-17143-6-git-send-email-jteki@openedev.com \
    --to=jteki@openedev.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox