From: Ian Campbell <ijc@hellion.org.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: musb: Power off OTG port VBUS when disabled
Date: Thu, 08 Sep 2016 13:04:07 +0100 [thread overview]
Message-ID: <1473336247.28111.49.camel@hellion.org.uk> (raw)
In-Reply-To: <20160907062521.23056-1-wens@csie.org>
On Wed, 2016-09-07 at 14:25 +0800, Chen-Yu Tsai wrote:
> The Linux kernel musb driver expects...
I don't much like this line of reasoning/explanation for changes to u-
boot. I appreciate that it might seem like all the world is Linux
(especially in sunxi context) but the right way to descibe these
changes IMHO is "A sensible behaviour for firmware is to ... because
..." i.e. to consider the general case.
Otherwise I might be tempted to say things like...
> VBUS to be off while initializing
> musb. Having it on results in a repeating string of warnings, followed
> > by an unusable peripheral.
... this sounds like it might be a Linux bug, perhaps it should be
fixed there?
Ian.
next prev parent reply other threads:[~2016-09-08 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 6:25 [U-Boot] [PATCH] sunxi: musb: Power off OTG port VBUS when disabled Chen-Yu Tsai
2016-09-08 12:04 ` Ian Campbell [this message]
2016-09-17 12:27 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473336247.28111.49.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox