From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Date: Wed, 14 Sep 2016 14:45:37 +0000
Subject: [U-Boot] [PATCH v1 1/5] tegra: usb gadget: fix ci udc operation
 if not hostpc capable
In-Reply-To: <fa7085b3-5e49-f09d-72cf-41320adadfb1@wwwdotorg.org>
References: <1473437441-938-1-git-send-email-marcel.ziswiler@toradex.com>
 <1473437441-938-2-git-send-email-marcel.ziswiler@toradex.com>
 <fa7085b3-5e49-f09d-72cf-41320adadfb1@wwwdotorg.org>
Message-ID: <1473864336.14918.10.camel@toradex.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, 2016-09-12 at 12:13 -0600, Stephen Warren wrote:
> On 09/09/2016 10:10 AM, Marcel Ziswiler wrote:
> > 
> > The Tegra 2 aka T20 is not host PC capable. Therefore move the
> > define
> > CONFIG_CI_UDC_HAS_HOSTPC from the generic tegra-common-usb-gadget.h
> > header file into resp. SoC type specific ones.
> This is OK, but ...
> 
> > 
> > diff --git a/include/configs/tegra-common-usb-gadget.h
> > b/include/configs/tegra-common-usb-gadget.h
> > 
> > ?#ifndef CONFIG_SPL_BUILD
> > ?/* USB gadget mode support*/
> > -#define CONFIG_CI_UDC_HAS_HOSTPC
> ... it seems a bit simpler to just wrap that in #ifndef
> CONFIG_TEGRA20.
> 
> That would avoid having to duplicate the define in all tegra*-
> common.h?
> forever. Still, it's not a huge deal.


Agreed, I will change this in a v2.