[U-Boot] [PATCH v1 1/5] tegra: usb gadget: fix ci udc operation if not hostpc capable

Stephen Warren
2016-09-12T18:13:18Z

On 09/09/2016 10:10 AM, Marcel Ziswiler wrote:
> The Tegra 2 aka T20 is not host PC capable. Therefore move the define
> CONFIG_CI_UDC_HAS_HOSTPC from the generic tegra-common-usb-gadget.h
> header file into resp. SoC type specific ones.

This is OK, but ...

> diff --git a/include/configs/tegra-common-usb-gadget.h b/include/configs/tegra-common-usb-gadget.h

> #ifndef CONFIG_SPL_BUILD
> /* USB gadget mode support*/
> -#define CONFIG_CI_UDC_HAS_HOSTPC

... it seems a bit simpler to just wrap that in #ifndef CONFIG_TEGRA20.

That would avoid having to duplicate the define in all tegra*-common.h
forever. Still, it's not a huge deal.