From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ajay Bhargav <ajay.bhargav@einfochips.com>
Date: Thu, 11 Aug 2011 10:37:23 +0530 (IST)
Subject: [U-Boot] [PATCH v5 1/2] gpio: Add GPIO driver framework for
 Marvell SoCs
In-Reply-To: <CALZhoSRXuAyUmHbdi2zjKNcuitB3aO=CUKrqVaPwgh_GWWYNFA@mail.gmail.com>
Message-ID: <1474045321.77841.1313039243899.JavaMail.root@ahm.einfochips.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


----- "Lei Wen" <adrian.wenl@gmail.com> wrote:
> 
> You should remove these two define, or we would met build error as:
> cmd_gpio.c:20: error: expected identifier before numeric constant
> cmd_gpio.c: In function 'do_gpio':
> cmd_gpio.c:49: error: 'GPIO_CLEAR' undeclared (first use in this
> function)
> cmd_gpio.c:49: error: (Each undeclared identifier is reported only
> once
> cmd_gpio.c:49: error: for each function it appears in.)
> cmd_gpio.c:50: error: 'GPIO_TOGGLE' undeclared (first use in this
> function)
> 
> Except this, other looks good to me, and I have verify the reset of
> patch on mmp3 board.
> 
> Thanks,
> Lei
> 
Hi Lei,

Thank you so much for pointing out. I tested library by simply defining
MARVELL_GPIO, I forgot to test with CMD_GPIO.

I will change the names and resubmit. sorry for mistake.

Thanks & Regards,
Ajay Bhargav