From: Chin Liang See <clsee@altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ddr: altera: Configuring SDRAM extra cycles timing parameters
Date: Wed, 21 Sep 2016 09:53:08 +0800 [thread overview]
Message-ID: <1474422788.2220.11.camel@altera.com> (raw)
In-Reply-To: <508f7680-e815-2b86-69c4-bd7de2ccb7ec@denx.de>
On Wed, 2016-09-21 at 03:20 +0200, Marek Vasut wrote:
> On 09/20/2016 08:05 AM, Chin Liang See wrote:
> > To enable configuration of sdr.ctrlcfg.extratime1 register which
> > enable
> > extra clocks for read to write command timing. This is critical to
> > ensure successful LPDDR2 interface
> >
> > Signed-off-by: Chin Liang See <clsee@altera.com>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > ---
> > Changes for v2
> > - Removed v1 patches #2 to #9 as no boards are using LPDDR2
> > ---
> > arch/arm/mach-socfpga/include/mach/sdram.h | 8 +++++++-
> > arch/arm/mach-socfpga/qts-filter.sh | 2 +-
> > arch/arm/mach-socfpga/wrap_sdram_config.c | 9 +++++++++
> > drivers/ddr/altera/sdram.c | 3 +++
> > 4 files changed, 20 insertions(+), 2 deletions(-)
> > [...]
>
> I'd really like to avoid the ifdef, can we do that (fix all boards to
> set the register to zero) ? Otherwise I'm fine with the patch.
>
Ok I know where you come from. ifdef will cause some test challenge in
term of coverage. In this case, let me fix all boards to zeroes.
Thanks
Chin Liang
>
next prev parent reply other threads:[~2016-09-21 1:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 6:05 [U-Boot] [PATCH v2] ddr: altera: Configuring SDRAM extra cycles timing parameters Chin Liang See
2016-09-21 1:20 ` Marek Vasut
2016-09-21 1:53 ` Chin Liang See [this message]
2016-09-21 9:55 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474422788.2220.11.camel@altera.com \
--to=clsee@altera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox