From: Jon Medhurst (Tixy) <tixy@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] vexpress: disable cci ace slave ports when booting in non-sec/hyp mode
Date: Mon, 26 Sep 2016 14:19:23 +0100 [thread overview]
Message-ID: <1474895963.3019.14.camel@linaro.org> (raw)
In-Reply-To: <a28ee97e-96e1-5f04-eda7-edb576f1803e@arm.com>
On Mon, 2016-09-26 at 13:38 +0100, Sudeep Holla wrote:
>
> On 26/09/16 13:30, Jon Medhurst (Tixy) wrote:
> > On Fri, 2016-09-23 at 17:38 +0100, Sudeep Holla wrote:
> >> Commit f225d39d3093 ("vexpress: Check TC2 firmware support before defaulting
> >> to nonsec booting") added support to check if the firmware on TC2 is
> >> configured appropriately before booting in nonsec/hyp mode.
> >>
> >> However when booting in non-secure/hyp mode, CCI control must be done in
> >> secure firmware and can't be done in non-secure/hyp mode. In order to
> >> ensure that, this patch disables the cci slave port inteface so that it
> >> is not accessed at all.
> >>
> >> Cc: Jon Medhurst <tixy@linaro.org>
> >> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
> >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> >> ---
> >
> > Acked-by: Jon Medhurst <tixy@linaro.org>
> > Tested-by: Jon Medhurst <tixy@linaro.org>
>
> So, can I assume the missing kernel patches to be reason for boot hang ?
> Just wanted to know if I need to investigate that any further ?
Sorry, yes they were the reason and no further investigation needed. I
remembered getting nonsec mode working some month's ago without such
patches, but I remember now that was by disabling MCPM in the kernel.
This morning I tried these U-Boot patches successfully with:
- Upstream vexpress_defconfig kernel booting with 'sec' mode
- That kernel with Lorenzo's patches in both 'sec' and 'nonsec'
- As above with CONFIG_BL_SWITCHER enabled
When booting in nonsec I also verified the device-tree modifications
made by this patch by seeing the following files existed and contained
the word 'disabled'...
/proc/device-tree/cci at 2c090000/slave-if at 4000/status
/proc/device-tree/cci at 2c090000/slave-if at 5000/status
--
Tixy
next prev parent reply other threads:[~2016-09-26 13:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 15:10 [U-Boot] [PATCH] vexpress: disable cci ace slave ports when booting in non-sec/hyp mode Sudeep Holla
2016-09-23 15:27 ` Marc Zyngier
2016-09-23 16:03 ` Jon Medhurst
2016-09-23 16:13 ` Sudeep Holla
2016-09-23 16:38 ` [U-Boot] [PATCH v2] " Sudeep Holla
2016-09-26 11:30 ` Jon Medhurst
2016-09-26 11:35 ` Sudeep Holla
2016-09-26 11:37 ` Sudeep Holla
2016-09-26 12:30 ` Jon Medhurst
2016-09-26 12:38 ` Sudeep Holla
2016-09-26 13:19 ` Jon Medhurst [this message]
2016-09-26 13:24 ` Sudeep Holla
2016-10-08 17:06 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474895963.3019.14.camel@linaro.org \
--to=tixy@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox