From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Kocialkowski Date: Sat, 15 Oct 2016 19:48:48 +0200 Subject: [U-Boot] [PATCH] power: twl6030: fix code refactoring In-Reply-To: References: <1476355673-16018-1-git-send-email-nicolae.rosia.oss@gmail.com> <1476451705.806.30.camel@paulk.fr> Message-ID: <1476553728.1127.2.camel@paulk.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, Le samedi 15 octobre 2016 ? 20:41 +0300, Nicolae Rosia a ?crit?: > Hi, > > On Fri, Oct 14, 2016 at 4:28 PM, Paul Kocialkowski wrote: > > > > Le jeudi 13 octobre 2016 ? 13:47 +0300, Nicolae Rosia a ?crit : > > > > > > From: Nicolae Rosia > > > > > > Commit a85362fb3e1fc7833723accddbbae431091d06b8 refactored the code > > > but the register read ended up in the wrong if branch. > > > Currently, the else branch checks a variable which is always 0. > > > > Good catch! Sorry for including that regression in the first place, I should > > have checked the patch more thoroughly. > No worries! > > > > > See comment below. > > The indentation before &value is inconsistent with what is done in the rest > > of > > the file. I think you should either just move the line as it was or only use > > one > > extra tab indent for the new line. Since this file breaks the 80 chars limit > > in > > a few places, I would tend to prefer the former. > > > checkpatch.pl was complaining, that's why I formatted it. Then I think you should fix the rest of the file accordingly. It doesn't make sense to introduce a variation in the coding style, as it creates inconsistency. IMO this is worse than having only subsequent changes conform to the global U-Boot coding style. > @Tom Rini, can you apply it either way? > > Best regards, > Nicolae -- Paul Kocialkowski, developer of free digital technology at the lower levels Website: https://www.paulk.fr/ Coding blog: https://code.paulk.fr/ Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: This is a digitally signed message part URL: