From: Walt Feasel <waltfeasel@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-BOOT][TEST PATCH 4/5] Cosmetic api: api_storage.c Comment style
Date: Wed, 23 Nov 2016 01:26:13 -0500 [thread overview]
Message-ID: <1479882374-18434-5-git-send-email-waltfeasel@gmail.com> (raw)
In-Reply-To: <1479882374-18434-1-git-send-email-waltfeasel@gmail.com>
Make comment style modifications
Signed-off-by: Walt Feasel <waltfeasel@gmail.com>
---
This patch series is to verify a correct patch submission.
Please let me know if there is a problem or preferred
wording for submitting cosmetic patches.
api/api_storage.c | 33 ++++++++++++++++++---------------
1 file changed, 18 insertions(+), 15 deletions(-)
diff --git a/api/api_storage.c b/api/api_storage.c
index 3db0979..c51ab30 100644
--- a/api/api_storage.c
+++ b/api/api_storage.c
@@ -116,8 +116,10 @@ static int dev_stor_get(int type, int first, int *more, struct device_info *di)
else
found = 1;
- /* provide hint if there are more devices in
- * this group to enumerate */
+ /*
+ * provide hint if there are more devices in
+ * this group to enumerate
+ */
if (1 < specs[type].max_dev)
*more = 1;
@@ -125,8 +127,10 @@ static int dev_stor_get(int type, int first, int *more, struct device_info *di)
for (i = 0; i < specs[type].max_dev; i++)
if (di->cookie ==
(void *)blk_get_dev(specs[type].name, i)) {
- /* previous cookie found -- advance to the
- * next device, if possible */
+ /*
+ * previous cookie found -- advance to the
+ * next device, if possible
+ */
if (++i >= specs[type].max_dev) {
/* out of range, no more to enum */
@@ -141,8 +145,10 @@ static int dev_stor_get(int type, int first, int *more, struct device_info *di)
else
found = 1;
- /* provide hint if there are more devices in
- * this group to enumerate */
+ /*
+ * provide hint if there are more devices in
+ * this group to enumerate
+ */
if ((i + 1) < specs[type].max_dev)
*more = 1;
@@ -171,9 +177,8 @@ static int dev_stor_get(int type, int first, int *more, struct device_info *di)
}
-/*
- * returns: ENUM_IDE, ENUM_USB etc. based on struct blk_desc
- */
+/* returns: ENUM_IDE, ENUM_USB etc. based on struct blk_desc */
+
static int dev_stor_type(struct blk_desc *dd)
{
int i, j;
@@ -187,9 +192,8 @@ static int dev_stor_type(struct blk_desc *dd)
}
-/*
- * returns: 0/1 whether cookie points to some device in this group
- */
+/* returns: 0/1 whether cookie points to some device in this group */
+
static int dev_is_stor(int type, struct device_info *di)
{
return (dev_stor_type(di->cookie) == type) ? 1 : 0;
@@ -300,9 +304,8 @@ int dev_enum_storage(struct device_info *di)
{
int i;
- /*
- * check: ide, usb, scsi, mmc
- */
+ /* check: ide, usb, scsi, mmc */
+
for (i = ENUM_IDE; i < ENUM_MAX; i++) {
if (dev_enum_stor(i, di))
return 1;
--
2.1.4
next prev parent reply other threads:[~2016-11-23 6:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 6:26 [U-Boot] [U-BOOT][TEST PATCH 0/5] Cosmetic modifications api_storage.c Walt Feasel
2016-11-23 6:26 ` [U-Boot] [U-BOOT][TEST PATCH 1/5] Cosmetic api: api_storage.c Align parenthesis Walt Feasel
2016-12-04 23:14 ` [U-Boot] [U-Boot, U-BOOT, TEST, " Tom Rini
2016-11-23 6:26 ` [U-Boot] [U-BOOT][TEST PATCH 2/5] Cosmetic api: api_storage.c Blank line after { Walt Feasel
2016-12-04 23:15 ` [U-Boot] [U-Boot, U-BOOT, TEST, " Tom Rini
2016-11-23 6:26 ` [U-Boot] [U-BOOT][TEST PATCH 3/5] Cosmetic api: api_storage.c Line over 80 char Walt Feasel
2016-12-04 23:15 ` [U-Boot] [U-Boot, U-BOOT, TEST, " Tom Rini
2016-11-23 6:26 ` Walt Feasel [this message]
2016-12-04 23:16 ` [U-Boot] [U-Boot, U-BOOT, TEST, 4/5] Cosmetic api: api_storage.c Comment style Tom Rini
2016-11-23 6:26 ` [U-Boot] [U-BOOT][TEST PATCH 5/5] Cosmetic api: api_storage.c Spelling correction Walt Feasel
2016-12-04 23:16 ` [U-Boot] [U-Boot, U-BOOT, TEST, " Tom Rini
2016-11-23 14:03 ` [U-Boot] [U-BOOT][TEST PATCH 0/5] Cosmetic modifications api_storage.c Walt Feasel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479882374-18434-5-git-send-email-waltfeasel@gmail.com \
--to=waltfeasel@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox